Closed Bug 1406912 Opened 7 years ago Closed 7 years ago

browser.find.find _serializeRangeData does not handle ranges found in same node properly

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(firefox-esr52 unaffected, firefox56 unaffected, firefox57- fixed, firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 - fixed
firefox58 --- fixed

People

(Reporter: u462496, Assigned: u462496)

References

Details

Attachments

(1 file, 3 obsolete files)

      No description provided.
See bug 1332144 comment 188.
Attachment #8916595 - Flags: review?(mixedpuppy)
[Tracking Requested - why for this release]: Bug inside new WebExtension API
Comment on attachment 8916595 [details] [diff] [review]
bug_1406912_fix_node_redeclaration.diff

I'd like to see tests.
Flags: needinfo?(kevinhowjones)
Added tests.
Attachment #8916595 - Attachment is obsolete: true
Attachment #8916595 - Flags: review?(mixedpuppy)
Flags: needinfo?(kevinhowjones)
Attachment #8916737 - Flags: review?(mixedpuppy)
Attachment #8916737 - Flags: review?(mixedpuppy) → review+
Added commit message.
Attachment #8916737 - Attachment is obsolete: true
Comment on attachment 8916746 [details] [diff] [review]
bug_1406912_fix_let_redeclaration_plus_test_2.diff

This patch is corrupted, will upload another one shortly.
Attachment #8916746 - Attachment is obsolete: true
Added commit message.
Whiteboard: [checkin-needed]
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/969e0b72c2ee
Fix _serializeRangeData does not handle ranges found in same node properly. r=mixedpuppy
Whiteboard: [checkin-needed]
I don't think I need to track this.
https://hg.mozilla.org/mozilla-central/rev/969e0b72c2ee
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Please request uplift to beta or set 57 status to wontfix.
Flags: needinfo?(kevinhowjones)
(In reply to Julien Cristau [:jcristau] from comment #12)
> Please request uplift to beta or set 57 status to wontfix.

I don't think I'm qualified to do this, nor would I really know what I was doing.  But I would like to see it uplifted to beta and it seems justified.  ni?ing Shane.
Flags: needinfo?(kevinhowjones) → needinfo?(mixedpuppy)
Comment on attachment 8916748 [details] [diff] [review]
bug_1406912_fix_let_redeclaration_plus_test_3.diff

Approval Request Comment
[Feature/Bug causing the regression]: find api
[User impact if declined]: find are incorrect in some instances
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: none
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: low
[Why is the change risky/not risky?]: actual code change is trivial (only reason I'm willing to request uplift at this point)
[String changes made/needed]: none
Flags: needinfo?(mixedpuppy)
Attachment #8916748 - Flags: approval-mozilla-beta?
Comment on attachment 8916748 [details] [diff] [review]
bug_1406912_fix_let_redeclaration_plus_test_3.diff

webext related, Beta57+
Attachment #8916748 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.