1407000 - Invalid error message for browserName, browserVersion, and platformName capabilities

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

The browserName, browserVersion, and platformName capabilities
return an error message saying the value "was not a boolean" when it
is not a string.  This is obviously meant to be "not a string".

>                 x @ "browserName" |
>                 x @ "browserVersion" |
>                 x @ "platformName" => if !value.is_string() {
>                         return Err(WebDriverError::new(ErrorStatus::InvalidArgument,
>                                                       format!("{} was not a boolean", x)))
>                     },

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1407000 - Fix error for string WebDriver capabilities.

Review commit: https://reviewboard.mozilla.org/r/187790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187790/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1407000 - Prefer error messages in the present.

s/was/is/ in various error messages for harmony.

Review commit: https://reviewboard.mozilla.org/r/187792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187792/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1407000 - Lint match_browser.

No functional changes here, but the indentation was wrong in many
places, making it very hard to read the code.

Review commit: https://reviewboard.mozilla.org/r/187794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187794/

Comment 4

[David Burns :automatedtester]

Comment on attachment 8916710 [details]
Bug 1407000 - Fix error for string WebDriver capabilities.

https://reviewboard.mozilla.org/r/187790/#review193074

Comment 5

[David Burns :automatedtester]

Comment on attachment 8916711 [details]
Bug 1407000 - Prefer error messages in the present.

https://reviewboard.mozilla.org/r/187792/#review193076

Comment 6

[David Burns :automatedtester]

Comment on attachment 8916712 [details]
Bug 1407000 - Lint match_browser.

https://reviewboard.mozilla.org/r/187794/#review193078

Comment 7

[David Burns :automatedtester]

Comment on attachment 8916711 [details]
Bug 1407000 - Prefer error messages in the present.

https://reviewboard.mozilla.org/r/187792/#review193080

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bcd6572f47d
Fix error for string WebDriver capabilities. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/5caa7a4686ab
Prefer error messages in the present. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/8751f6fd0421
Lint match_browser. r=automatedtester

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3bcd6572f47d
https://hg.mozilla.org/mozilla-central/rev/5caa7a4686ab
https://hg.mozilla.org/mozilla-central/rev/8751f6fd0421