Closed Bug 1407000 Opened 3 years ago Closed 3 years ago

Invalid error message for browserName, browserVersion, and platformName capabilities

Categories

(Testing :: geckodriver, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(3 files)

The browserName, browserVersion, and platformName capabilities
return an error message saying the value "was not a boolean" when it
is not a string.  This is obviously meant to be "not a string".

>                 x @ "browserName" |
>                 x @ "browserVersion" |
>                 x @ "platformName" => if !value.is_string() {
>                         return Err(WebDriverError::new(ErrorStatus::InvalidArgument,
>                                                       format!("{} was not a boolean", x)))
>                     },
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attachment #8916710 - Flags: review?(hskupin) → review?(dburns)
Attachment #8916711 - Flags: review?(hskupin) → review?(dburns)
Attachment #8916712 - Flags: review?(hskupin) → review?(dburns)
Comment on attachment 8916710 [details]
Bug 1407000 - Fix error for string WebDriver capabilities.

https://reviewboard.mozilla.org/r/187790/#review193074
Attachment #8916710 - Flags: review?(dburns) → review+
Comment on attachment 8916711 [details]
Bug 1407000 - Prefer error messages in the present.

https://reviewboard.mozilla.org/r/187792/#review193076
Comment on attachment 8916712 [details]
Bug 1407000 - Lint match_browser.

https://reviewboard.mozilla.org/r/187794/#review193078
Attachment #8916712 - Flags: review?(dburns) → review+
Comment on attachment 8916711 [details]
Bug 1407000 - Prefer error messages in the present.

https://reviewboard.mozilla.org/r/187792/#review193080
Attachment #8916711 - Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bcd6572f47d
Fix error for string WebDriver capabilities. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/5caa7a4686ab
Prefer error messages in the present. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/8751f6fd0421
Lint match_browser. r=automatedtester
You need to log in before you can comment on or make changes to this bug.