1407021 - Button font-size is too small in info-pages

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1407021 - Ensure in-content button font-size is not overridden by widget styling (e.g. in forms.css).

Review commit: https://reviewboard.mozilla.org/r/187820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187820/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8916742 [details]
Bug 1407021 - Ensure in-content button font-size is not overridden by widget styling (e.g. in forms.css).

https://reviewboard.mozilla.org/r/187820/#review192872

Oh my, that was quite annoying indeed, thank you for fixing it! Please file for uplift. :)

Comment 3

[Dão Gottwald [:dao]]

Please put a bit more effort into bug filing. I'm assuming this is a Mac-only issue?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61aeae25af58
Ensure in-content button font-size is not overridden by widget styling (e.g. in forms.css). r=johannh

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Dão Gottwald [::dao] from comment #3)
> Please put a bit more effort into bug filing. I'm assuming this is a
> Mac-only issue?

My bad with the component, at the time of filing I had not yet thought about it enough to realize it would be a Toolkit bug. And no, it affects Windows as well.

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

FWIW: off the top of my head, this bug affects about:tabcrashed and about:neterror.

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8916742 [details]
Bug 1407021 - Ensure in-content button font-size is not overridden by widget styling (e.g. in forms.css).

Approval Request Comment
[Feature/Bug causing the regression]: I can't find the regressing bug#, but I believe it happened when unifying some in-content stylesheets :(
[User impact if declined]: The font size of buttons in in-content pages (particularly neterror pages) is noticeably small
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: minor CSS change - in particular, it simply ensures the font-size is inherited and does not actually change any values.
[String changes made/needed]: none

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/61aeae25af58

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916742 [details]
Bug 1407021 - Ensure in-content button font-size is not overridden by widget styling (e.g. in forms.css).

UI polish, Beta57+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7185be26d0db