Closed Bug 1407021 Opened 2 years ago Closed 2 years ago

Button font-size is too small in info-pages

Categories

(Toolkit :: Themes, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: nhnt11, Assigned: nhnt11)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Attachment #8916742 - Flags: review?(dao+bmo) → review?(jhofmann)
Comment on attachment 8916742 [details]
Bug 1407021 - Ensure in-content button font-size is not overridden by widget styling (e.g. in forms.css).

https://reviewboard.mozilla.org/r/187820/#review192872

Oh my, that was quite annoying indeed, thank you for fixing it! Please file for uplift. :)
Attachment #8916742 - Flags: review?(jhofmann) → review+
Please put a bit more effort into bug filing. I'm assuming this is a Mac-only issue?
Component: Theme → Themes
Flags: needinfo?(nhnt11)
Product: Firefox → Toolkit
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/61aeae25af58
Ensure in-content button font-size is not overridden by widget styling (e.g. in forms.css). r=johannh
(In reply to Dão Gottwald [::dao] from comment #3)
> Please put a bit more effort into bug filing. I'm assuming this is a
> Mac-only issue?

My bad with the component, at the time of filing I had not yet thought about it enough to realize it would be a Toolkit bug. And no, it affects Windows as well.
Flags: needinfo?(nhnt11)
Summary: In-content button font-size is too small → Button font-size is too small in info-pages
FWIW: off the top of my head, this bug affects about:tabcrashed and about:neterror.
Comment on attachment 8916742 [details]
Bug 1407021 - Ensure in-content button font-size is not overridden by widget styling (e.g. in forms.css).

Approval Request Comment
[Feature/Bug causing the regression]: I can't find the regressing bug#, but I believe it happened when unifying some in-content stylesheets :(
[User impact if declined]: The font size of buttons in in-content pages (particularly neterror pages) is noticeably small
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: minor CSS change - in particular, it simply ensures the font-size is inherited and does not actually change any values.
[String changes made/needed]: none
Attachment #8916742 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/61aeae25af58
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Comment on attachment 8916742 [details]
Bug 1407021 - Ensure in-content button font-size is not overridden by widget styling (e.g. in forms.css).

UI polish, Beta57+
Attachment #8916742 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.