Closed
Bug 1407070
Opened 7 years ago
Closed 7 years ago
Remove HP-UX DCE threads support (_PR_DCETHREADS)
Categories
(NSPR :: NSPR, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
4.18
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file, 1 obsolete file)
|
48.63 KB,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
NSPR's pthreads code can be simplified if it doesn't need to support the ancient HP-UX DCE threads (an earlier draft of the pthreads standard). I generated by patch by searching for "_PR_DCETHREADS" and then searching for "DCE" in the NSPR source tree. To review the patch, assume the macro _PR_DCETHREADS is undefined.
Attachment #8916806 -
Flags: review?(kaie)
|
Assignee | |
Comment 1•7 years ago
|
||
Changes from the previous patch: 1. I resurrected the dceemu.c test program. I found that this is the only test program of the DCE emulation API, declared in the prdce.h header. If we remove dceemu.c, then nothing uses the functions declared in prdce.h. I changed dceemu.c so that it does not require _PR_DCETHREADS to be defined. 2. I removed the -ldce linker flag (HP-UX 10.x only) from two Makefile.in files.
Attachment #8916806 -
Attachment is obsolete: true
Attachment #8916806 -
Flags: review?(kaie)
Attachment #8916837 -
Flags: review?(kaie)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8916837 [details] [diff] [review] Patch v2: Remove HP-UX DCE threads support (_PR_DCETHREADS) r=kaie
Attachment #8916837 -
Flags: review?(kaie) → review+
|
|
||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/projects/nspr/rev/536b0f74d4cce02017b0bb27f44bba7dd495f179 Thanks Wan-Teh
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.18
You need to log in
before you can comment on or make changes to this bug.
Description
•