1407174 - Cannot submit scheduled change to alias "esr52": Invalid input for rule_id. Not an integer. rule_id: u'esr52' is not a 'rule_id'

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[Johan Lorenzo [:jlorenzo]]

Happened during 52.4.1[1]: 

> 01:40:48     INFO -  "HEAD /api/rules/esr52 HTTP/1.1" 200 0
> 01:40:48     INFO -  REQUEST STATS: {"url": "https://aus4-admin.mozilla.org/api/rules/esr52", "timestamp": 1507624848.115971, "method": "HEAD", "elapsed_secs": 0.23516201972961426, "status_code": 200}
> 01:40:48     INFO -  Balrog request to https://aus4-admin.mozilla.org/api/scheduled_changes/rules
> 01:40:48     INFO -  Data sent: {u'comment': u'esr52 rule', 'change_type': 'update', u'fallbackMapping': u'Firefox-52.4.0esr-build2', u'buildID': None, u'backgroundRate': 100, u'product': u'Firefox', u'instructionSet': None, u'mapping': 'Firefox-52.4.1esr-build1', u'alias': u'esr52', u'headerArchitecture': None, u'buildTarget': None, 'data_verison': 15, u'osVersion': None, u'distVersion': None, u'mig64': None, u'data_version': 15, 'when': 1507568400000, u'priority': 94, u'locale': None, u'version': None, u'update_type': u'minor', u'memory': None, u'distribution': None, u'rule_id': 'esr52', u'channel': u'esr'}
> 01:40:48     INFO -  "POST /api/scheduled_changes/rules HTTP/1.1" 400 166
> 01:40:48     INFO -  Caught HTTPError: {
> 01:40:48     INFO -    "detail": "Invalid input for rule_id. Not an integer. rule_id: u'esr52' is not a 'rule_id'",
> 01:40:48     INFO -    "status": 400,
> 01:40:48     INFO -    "title": "Bad Request",
> 01:40:48     INFO -    "type": "about:blank"
> 01:40:48     INFO -  }
> 01:40:48     INFO -  REQUEST STATS: {"url": "https://aus4-admin.mozilla.org/api/scheduled_changes/rules", "timestamp": 1507624848.168036, "method": "POST", "elapsed_secs": 0.05174899101257324, "status_code": 400}
> 01:40:48     INFO -  Traceback (most recent call last):
> 01:40:48     INFO -    File "/builds/slave/rel-m-esr52-fx_sc_p_in_balrog-/build/tools/scripts/build-promotion/balrog-release-shipper.py", line 54, in <module>
> 01:40:48     INFO -      args.build_number, args.rule_ids, args.schedule_at)
> 01:40:48     INFO -    File "/builds/slave/rel-m-esr52-fx_sc_p_in_balrog-/build/tools/scripts/build-promotion/../../lib/python/balrog/submitter/cli.py", line 540, in run
> 01:40:48     INFO -      ).add_scheduled_rule_change(**data)
> 01:40:48     INFO -    File "/builds/slave/rel-m-esr52-fx_sc_p_in_balrog-/build/tools/lib/python/vendor/balrogclient-0.0.4/balrogclient/api.py", line 254, in add_scheduled_rule_change
> 01:40:48     INFO -      return self.request(method='POST', data=rule_data)
> 01:40:48     INFO -    File "/builds/slave/rel-m-esr52-fx_sc_p_in_balrog-/build/tools/lib/python/vendor/balrogclient-0.0.4/balrogclient/api.py", line 111, in request
> 01:40:48     INFO -      return self.do_request(url, data, method)
> 01:40:48     INFO -    File "/builds/slave/rel-m-esr52-fx_sc_p_in_balrog-/build/tools/lib/python/vendor/balrogclient-0.0.4/balrogclient/api.py", line 130, in do_request
> 01:40:48     INFO -      req.raise_for_status()
> 01:40:48     INFO -    File "/builds/slave/rel-m-esr52-fx_sc_p_in_balrog-/build/tools/scripts/build-promotion/../../lib/python/vendor/requests-2.7.0/requests/models.py", line 851, in raise_for_status
> 01:40:48     INFO -      raise HTTPError(http_error_msg, response=self)
> 01:40:48     INFO -  requests.exceptions.HTTPError: 400 Client Error: BAD REQUEST
> 01:40:48    ERROR - Return code: 1

Not a big deal for 52.4.1, it was a macos-only version. We didn't want the automatic scheduled change, anyway. This might be good to fix for next ESR, though.

[1] https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-esr52-noarch/release-mozilla-esr52-firefox_schedule_publishing_in_balrog-bm73-build1-build3.txt.gz

Comment 1

[Johan Lorenzo [:jlorenzo]]

Bug 1388323 shows that this issue has been here since 52.3.0.

Comment 2

[[e-mail] (:bhearsum)]

This is because scheduled changes do not support alias' for rule_ids in their HTTP requests.

Comment 3

[Johan Lorenzo [:jlorenzo]]

We use a workaround while bug 1374638 is resolved.

Comment 4

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #3)
> We use a workaround while bug 1374638 is resolved.
We can* use. The idea is to hardcode the rule ID, instead of using the alias.

Comment 5

[Johan Lorenzo [:jlorenzo]]

The rule ID is already used in m-c, m-b, m-r, but some parts of bug 1373647 haven't been uplifted to esr52[2]

[1] https://hg.mozilla.org/releases/mozilla-release/file/ca38c18d63f9/testing/mozharness/configs/releases/updates_firefox_esr52.py#l31
[2] https://hg.mozilla.org/releases/mozilla-esr52/file/2b30335d0b95/testing/mozharness/configs/releases/updates_firefox_esr52.py#l31

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: bug-1407174.patch

Comment 7

[Johan Lorenzo [:jlorenzo]]

Workaround landed on esr52 at: https://hg.mozilla.org/releases/mozilla-esr52/rev/e6a35d68f4e7fc1194660f39a3f42fe18c74f0e8