Closed Bug 1407270 Opened 2 years ago Closed 2 years ago

[MIPS] Add missing failure handling changes from bug 1360211

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36



Actual results:

Adds missing handling of RESUME_WASM in handleFailureWithHandlerTail for mips32[64] form Bug 1360211. Makes asm.js/testFFI.js pass on mips32.
Attached patch bug1407270.patchSplinter Review
Attachment #8917014 - Flags: review?(bbouvier)
Comment on attachment 8917014 [details] [diff] [review]
bug1407270.patch

Review of attachment 8917014 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks and sorry for missing those!
Attachment #8917014 - Flags: review?(bbouvier) → review+
Keywords: checkin-needed
Assignee: nobody → dragan.mladjenovic
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/963670ce2751
[MIPS] Add missing failure handling changes from bug 1360211. r=bbouvier
Keywords: checkin-needed
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/963670ce2751
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.