Closed
Bug 1407298
Opened 7 years ago
Closed 7 years ago
Don't run SprintfLiteralChecker for third-party sources
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox58 affected)
RESOLVED
INVALID
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | affected |
People
(Reporter: anba, Unassigned)
References
Details
From https://treeherder.mozilla.org/#/jobs?repo=try&revision=f54890bdbfc55c03880c44d8485ce248105fd42f
Linux x64 opt (and other targets) reports:
---
/builds/worker/workspace/build/src/intl/icu/source/i18n/number_decimalquantity.cpp:986:5: error: Use SprintfLiteral instead of snprintf when writing into a character array.
---
I'd expect the existing third-party exclusion allows snprintf calls in ICU: https://searchfox.org/mozilla-central/rev/b53e29293c9e9a2905f4849f4e3c415e2013f0cb/tools/rewriting/ThirdPartyPaths.txt#19
|
Reporter | |
Comment 1•7 years ago
|
||
Ah, so the third party check must be called manually in each plugin:
https://searchfox.org/mozilla-central/rev/b53e29293c9e9a2905f4849f4e3c415e2013f0cb/build/clang-plugin/NonParamInsideFunctionDeclChecker.cpp#84
|
|
Reporter | |
Updated•7 years ago
|
Summary: Thirdparty exclusion for ICU doesn't work for snprintf calls in ICU60 → Don't run SprintfLiteralChecker for third-party sources
|
|
Reporter | |
Comment 2•7 years ago
|
||
Ugh nvm, I didn't see isIgnoredPathForSprintfLiteral... :-/
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•