Closed Bug 1407298 Opened 4 years ago Closed 4 years ago

Don't run SprintfLiteralChecker for third-party sources

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set
major

Tracking

(firefox58 affected)

RESOLVED INVALID
Tracking Status
firefox58 --- affected

People

(Reporter: anba, Unassigned)

References

Details

From https://treeherder.mozilla.org/#/jobs?repo=try&revision=f54890bdbfc55c03880c44d8485ce248105fd42f

Linux x64 opt (and other targets) reports:
---
/builds/worker/workspace/build/src/intl/icu/source/i18n/number_decimalquantity.cpp:986:5: error: Use SprintfLiteral instead of snprintf when writing into a character array.
---

I'd expect the existing third-party exclusion allows snprintf calls in ICU: https://searchfox.org/mozilla-central/rev/b53e29293c9e9a2905f4849f4e3c415e2013f0cb/tools/rewriting/ThirdPartyPaths.txt#19
Summary: Thirdparty exclusion for ICU doesn't work for snprintf calls in ICU60 → Don't run SprintfLiteralChecker for third-party sources
Ugh nvm, I didn't see isIgnoredPathForSprintfLiteral... :-/
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.