1407352 - Avoid calling GetChildAt() in DeleteRangeTransaction::CreateTxnsToDeleteBetween()

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Comment 1

[(no longer active)]

Attachment: Avoid calling GetChildAt() in DeleteRangeTransaction::CreateTxnsToDeleteBetween()

Comment 2

[(no longer active)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9367435f7d768f51340ee52e0c851540bace40a

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8917083 [details] [diff] [review]
Avoid calling GetChildAt() in DeleteRangeTransaction::CreateTxnsToDeleteBetween()

>@@ -148,17 +151,17 @@ DeleteRangeTransaction::CreateTxnsToDeleteBetween(nsINode* aNode,
>     // So, the transaction shouldn't be recorded.
>     if (NS_WARN_IF(!deleteTextTransaction->CanDoIt())) {
>       return NS_ERROR_FAILURE;
>     }
>     AppendChild(deleteTextTransaction);
>     return NS_OK;
>   }
> 
>-  nsCOMPtr<nsIContent> child = aNode->GetChildAt(aStartOffset);
>+  nsCOMPtr<nsIContent> child = aChildAtStartOffset;

|child| is used only for initializing DeleteNodeTransaction() and calling GetNextSibling(). So, this can be nsIContent*.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccda121ca4b1
Avoid calling GetChildAt() in DeleteRangeTransaction::CreateTxnsToDeleteBetween(); r=masayuki

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ccda121ca4b1