Closed
Bug 1407408
Opened 7 years ago
Closed 7 years ago
Add waitForTick to TestUtils.jsm
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
|
844 bytes,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
We have tons of tests relying on the broken Promise scheduling.
In many cases just waiting for a tick is enough to fix the issue.
This is adding a simple helper for that.
(I have no idea who should review these changes, so picking up randomly)
Attachment #8917130 -
Flags: review?(paolo.mozmail)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8917130 [details] [diff] [review]
add_wait_for_tick.diff
This shared helper function is definitely useful. Thanks!
This query highlights just a few of the places that could use it:
https://dxr.mozilla.org/mozilla-central/search?q=executeSoon(resolve)&redirect=false
Attachment #8917130 -
Flags: review?(paolo.mozmail) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c380466c97d6
Add waitForTick to TestUtils.jsm, r=paolo
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in
before you can comment on or make changes to this bug.
Description
•