1407435 - Removing item from toolbar via context menu makes toolbar icon invisible

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Tim Nguyen :ntim]

STR:
- Right click on any toolbar button
- Click "Remove from Toolbar"
- Go inside customization mode

AR:
- The button that was just removed has an invisible icon

ER:
- The button icon should be visible


It seems like the animate-out class is not properly removed.

Comment 1

[Tim Nguyen :ntim]

Regression of bug 1390313

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Erica, could you take this?

Comment 3

[Erica Wright [:ewright]]

Attachment: Bug 1407435 - After animating out from the toolbar, the widget no longer remains invisible.

Review commit: https://reviewboard.mozilla.org/r/188470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188470/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8917513 [details]
Bug 1407435 - After animating out from the toolbar, the widget no longer remains invisible.

https://reviewboard.mozilla.org/r/188470/#review193730

Thanks, I was able to reproduce the bug (aNode.parentNode is null) as well as confirm that the patch fixed it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/462c85ecfe5b
After animating out from the toolbar, the widget no longer remains invisible. r=jaws

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/462c85ecfe5b

Comment 7

[Stefan [:StefanG_QA]]

I was able to reproduce the issue on Nightly build (2017-10-10) using Windows 7 x64. 

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Verified fixed on latest Nightly 58.0a1 (2017-10-16) across platforms: Windows 10 x64, Windows 7 x64, Mac OS X 10.13 and Ubuntu 16.04 x64.