Closed Bug 1407435 Opened 3 years ago Closed 3 years ago
Removing item from toolbar via context menu makes toolbar icon invisible
59 bytes, text/x-review-board-request
STR: - Right click on any toolbar button - Click "Remove from Toolbar" - Go inside customization mode AR: - The button that was just removed has an invisible icon ER: - The button icon should be visible It seems like the animate-out class is not properly removed.
Regression of bug 1390313
Erica, could you take this?
Priority: -- → P3
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Assignee: nobody → ewright
Comment on attachment 8917513 [details] Bug 1407435 - After animating out from the toolbar, the widget no longer remains invisible. https://reviewboard.mozilla.org/r/188470/#review193730 Thanks, I was able to reproduce the bug (aNode.parentNode is null) as well as confirm that the patch fixed it.
Attachment #8917513 - Flags: review?(jaws) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/462c85ecfe5b After animating out from the toolbar, the widget no longer remains invisible. r=jaws
I was able to reproduce the issue on Nightly build (2017-10-10) using Windows 7 x64. Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 Verified fixed on latest Nightly 58.0a1 (2017-10-16) across platforms: Windows 10 x64, Windows 7 x64, Mac OS X 10.13 and Ubuntu 16.04 x64.
You need to log in before you can comment on or make changes to this bug.