1407463 - stylo: Drop unused pseudo nsAtom from some methods for ServoStyleSet

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

nsAtom* for pseudo element is no longer used in ServoStyleSet::ResolveStyleLazily, ServoStyleSet::ResolveStyleLazilyInternal and ServoStyleSet::GetBaseContextForElement.  We can drop them.

I noticed this fact while I was writing a rough patch for bug 1303235.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37c7f4710526a5ac011acdb44426609176931de3

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1407463 - Drop unused pseudo atom argument from ResolveStyleLazily and ResolveStyleLazilyInternal.

Review commit: https://reviewboard.mozilla.org/r/188216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188216/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1407463 - Drop unused pseudo atom argument from GetBaseContextForElement.

Review commit: https://reviewboard.mozilla.org/r/188218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188218/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8917207 [details]
Bug 1407463 - Drop unused pseudo atom argument from ResolveStyleLazily and ResolveStyleLazilyInternal.

https://reviewboard.mozilla.org/r/188216/#review193434

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8917208 [details]
Bug 1407463 - Drop unused pseudo atom argument from GetBaseContextForElement.

https://reviewboard.mozilla.org/r/188218/#review193436

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Thanks for the review!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e04d20a6e92
Drop unused pseudo atom argument from ResolveStyleLazily and ResolveStyleLazilyInternal. r=heycam
https://hg.mozilla.org/integration/autoland/rev/783d4ff0cd91
Drop unused pseudo atom argument from GetBaseContextForElement. r=heycam

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4e04d20a6e92
https://hg.mozilla.org/mozilla-central/rev/783d4ff0cd91

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Does this need uplift to Beta or can it ride the 58 train?

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Not worth uplifting.