Closed Bug 1407463 Opened 3 years ago Closed 3 years ago

stylo: Drop unused pseudo nsAtom from some methods for ServoStyleSet

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(2 files)

nsAtom* for pseudo element is no longer used in ServoStyleSet::ResolveStyleLazily, ServoStyleSet::ResolveStyleLazilyInternal and ServoStyleSet::GetBaseContextForElement.  We can drop them.

I noticed this fact while I was writing a rough patch for bug 1303235.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37c7f4710526a5ac011acdb44426609176931de3
Comment on attachment 8917207 [details]
Bug 1407463 - Drop unused pseudo atom argument from ResolveStyleLazily and ResolveStyleLazilyInternal.

https://reviewboard.mozilla.org/r/188216/#review193434
Attachment #8917207 - Flags: review?(cam) → review+
Comment on attachment 8917208 [details]
Bug 1407463 - Drop unused pseudo atom argument from GetBaseContextForElement.

https://reviewboard.mozilla.org/r/188218/#review193436
Attachment #8917208 - Flags: review?(cam) → review+
Thanks for the review!
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e04d20a6e92
Drop unused pseudo atom argument from ResolveStyleLazily and ResolveStyleLazilyInternal. r=heycam
https://hg.mozilla.org/integration/autoland/rev/783d4ff0cd91
Drop unused pseudo atom argument from GetBaseContextForElement. r=heycam
https://hg.mozilla.org/mozilla-central/rev/4e04d20a6e92
https://hg.mozilla.org/mozilla-central/rev/783d4ff0cd91
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Does this need uplift to Beta or can it ride the 58 train?
Flags: needinfo?(hikezoe)
Not worth uplifting.
Flags: needinfo?(hikezoe)
You need to log in before you can comment on or make changes to this bug.