1407540 - MozURL should support base url in the CTOR

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Andrea Marchesini [:baku]]

This is required by the porting of URL API to MozURL.

Comment 1

[Valentin Gosu [:valentin]]

Attachment: Bug 1407540 - Allow MozURL to be constructed with a base URL

Review commit: https://reviewboard.mozilla.org/r/188326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188326/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8917313 [details]
Bug 1407540 - Allow MozURL to be constructed with a base URL

https://reviewboard.mozilla.org/r/188326/#review193512


C/C++ static analysis found 2 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: netwerk/test/gtest/TestMozURL.cpp:105
(Diff revision 1)
>    // Test that the mutator will not work after one faulty operation
>    mut.SetScheme(NS_LITERAL_CSTRING("test"));
>    ASSERT_EQ(mut.GetStatus(), NS_ERROR_MALFORMED_URI);
>  }
> +
> +TEST(TestMozURL, InitWithBase)

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

::: netwerk/test/gtest/TestMozURL.cpp:105
(Diff revision 1)
>    // Test that the mutator will not work after one faulty operation
>    mut.SetScheme(NS_LITERAL_CSTRING("test"));
>    ASSERT_EQ(mut.GetStatus(), NS_ERROR_MALFORMED_URI);
>  }
> +
> +TEST(TestMozURL, InitWithBase)

Warning: Use '= delete' to prohibit calling of a special member function [clang-tidy: modernize-use-equals-delete]

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8917313 [details]
Bug 1407540 - Allow MozURL to be constructed with a base URL

https://reviewboard.mozilla.org/r/188326/#review193560

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bab0d9666afb
Allow MozURL to be constructed with a base URL r=mayhemer

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bab0d9666afb