Closed Bug 1407540 Opened 2 years ago Closed 2 years ago

MozURL should support base url in the CTOR

Categories

(Core :: Networking, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: baku, Assigned: valentin)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

This is required by the porting of URL API to MozURL.
Blocks: 1406933
Assignee: nobody → valentin.gosu
Priority: -- → P1
Whiteboard: [necko-triaged]
Comment on attachment 8917313 [details]
Bug 1407540 - Allow MozURL to be constructed with a base URL

https://reviewboard.mozilla.org/r/188326/#review193512


C/C++ static analysis found 2 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: netwerk/test/gtest/TestMozURL.cpp:105
(Diff revision 1)
>    // Test that the mutator will not work after one faulty operation
>    mut.SetScheme(NS_LITERAL_CSTRING("test"));
>    ASSERT_EQ(mut.GetStatus(), NS_ERROR_MALFORMED_URI);
>  }
> +
> +TEST(TestMozURL, InitWithBase)

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

::: netwerk/test/gtest/TestMozURL.cpp:105
(Diff revision 1)
>    // Test that the mutator will not work after one faulty operation
>    mut.SetScheme(NS_LITERAL_CSTRING("test"));
>    ASSERT_EQ(mut.GetStatus(), NS_ERROR_MALFORMED_URI);
>  }
> +
> +TEST(TestMozURL, InitWithBase)

Warning: Use '= delete' to prohibit calling of a special member function [clang-tidy: modernize-use-equals-delete]
Comment on attachment 8917313 [details]
Bug 1407540 - Allow MozURL to be constructed with a base URL

https://reviewboard.mozilla.org/r/188326/#review193560
Attachment #8917313 - Flags: review?(honzab.moz) → review+
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bab0d9666afb
Allow MozURL to be constructed with a base URL r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/bab0d9666afb
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.