1407604 - Fullscreen controls for videos are missing on baishi.baidu.com

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect, P1)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 58.0a1 (2017-10-10)
- DevEdition 57.0b7 build1 (20171009192146)
- 57.0b7 build1 (20171009192146)
- 56.0.1 build2 (20171002220106)

[Affected platforms]:
- Windows 10 x64
- macOS 10.13	
- Ubuntu 16.04 x64

[Steps to reproduce]:
1. Launch Firefox
2. Go to http://baishi.baidu.com/, choose a random video and play it (e.g. http://baishi.baidu.com/watch/2512640864030701220.html?&recFrom=site&list=4)
3. Click the fullscreen button 

[Expected result]:
- The fullscreen button is functional
- The video is properly played in normal and fullscreen modes

[Actual result]:
- The fullscreen button is inactive 

[Regression range]:
- This issue is reproducible all the way back to 29.0a1 (2014-01-02), so it isn't a recent regression

[Additional notes]:
- The issue is not triggered in Google Chrome

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

This is a Flash or Full Screen issue, not a video playback issue.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

The relevant code is:
> else if (n.className.has(o, "zoom-in")) try {
>     e.video.webkitEnterFullscreen(), e.play()
> } catch (a) {
>     e.play()
> }
(in http://vs5.bdstatic.com/browse_static/v3/common/pkg/common_a2eb1a04.js)

Apparently this would only work in WebKit-based browsers...

Also there is some other code like:
> document.fullscreenEnabled || document.webkitFullscreenEnabled ? e.video.webkitEnterFullscreen() : document.fullscreenEnabled || document.mozFullScreenEnabled ? e.video.mozRequestFullScreen() : (document.fullscreenEnabled || document.msFullscreenEnabled) && e.video.msRequestFullscreen()

This seems to be something which would stop working once we ship unprefixed Fullscreen API...

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Maybe we would need to add webkit-prefixed Fullscreen API at some point :/

Comment 4

[Adam Stevenson [:adamopenweb]]

I am able to get full screen on this video in MacOS http://baishi.baidu.com/watch/2512640864030701220.html?&recFrom=site&list=4. 

Iulia - Can you still reproduce?

Comment 5

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Adam Stevenson [:adamopenweb] from comment #4)
> I am able to get full screen on this video in MacOS
> http://baishi.baidu.com/watch/2512640864030701220.html?&recFrom=site&list=4. 
> 
> Iulia - Can you still reproduce?

The initial issue is not reproducible anymore on Windows 10 x64, Ubuntu 16.04 and macOS 10.13.3, using: 
- 61.0a1 (2018-04-22)
- 60.0b14 build2 (20180419200216)
- 59.0.2 build1 (20180323154952)
- 58.0a1 (2017-10-10) - when the bug was reported
So it seems this was a site issue. 
The behaviour is this instead: https://drive.google.com/file/d/11nj5927TzkrSNlr7cAKjA6-BD10auRHl/view?usp=sharing. The fullscreen button is functional when the video is in normal mode. After that, the seekbar and the rest of the controls are missing when in fullscreen mode.

Comment 6

[Adam Stevenson [:adamopenweb]]

I can reproduce the video controls not appearing in full screen. When viewing in Chrome, it appears they are relying on the native controls in full screen.

Comment 7

[Adam Stevenson [:adamopenweb]]

Maybe Dennis can take a look into this issue?

Comment 8

[Dennis Schubert [:denschub]]

This, for once, is not related to us unprefixing the full screen API in unreleased builds, so that's good. However, it is also not a regression, so I'll remove the keyword.

Keeping the ni? alive until I finished diagnosis here.

Comment 9

[Dennis Schubert [:denschub]]

So, this issue is related to bug 713608 and I suggest reading https://bugzilla.mozilla.org/show_bug.cgi?id=713608#c46 for more context. In short: We don't show native video controls when in fullscreen, other browsers do. According to the spec, either behavior is fine, but we should probably follow the others here.

Suggesting a workaround is really difficult, though. They could set the controls attribute in their fullscreenchange event, making the controls explicit, which would result in the same rendering across platforms, as far as I can tell. Another possibility would be to have div#playerSection as the full screen element, rather than the video element itself. That would result in their video controls showing up in the full screen view. However, that may affect the mobile UX, so simply setting the controls attribute may be the way to go, until we have that fixed on our side.

Comment 10

[Adam Stevenson [:adamopenweb]]

Maybe Bingqing Li can help with contacting Baidu for us?

Comment 11

[Bingqing Li]

We already started the contact with Baidu, and I'll keep you informed.

Comment 12

[Firefox Bug Husbandry Bot]

See bug 1547409. Moving webcompat whiteboard tags to keywords.

Comment 13

[Raul Bucata]

It seems that the issue has been fixed, as I was not able to reproduce the issue. The functionality of the full-screen button works as expected, if I follow this video: http://v.baidu.com/watch/05528934612422711806.html?fr=v.baidu.com/channel/short/newamuse&tabfr=/channel/short/newamuse

https://media.giphy.com/media/KZhpfB1rkvUOpote83/giphy.gif

Tested with:

Browser / Version: Firefox Nightly 101.0a1 (2022-04-05) (64-bit)
Operating System: Windows 10 PRO x64