1407637 - Fennec mark release as shipped in-tree task

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement, P1)

Description

[Rail Aliiev [:rail]]

+++ This bug was initially created as a clone of Bug #1406517 +++

Let's build a bbb task in-tree for marking Fennec release as shipped.
This will allow for firefox "mark release as shipped" as well.

Comment 1

[Rail Aliiev [:rail]]

Attachment: release-mark-as-shipped.diff

Probably this should just work...

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8917405 [details] [diff] [review]
release-mark-as-shipped.diff

LGTM.

I think we need to add a dependency on push-to-releases once that's a task. We probably need to add it to the publish_fennec target_tasks_method as well.

On this line [1] we probably need a code block like

if task.task['payload'].get('properties', {}).get('product') == 'fennec':
    if task.kind in ('release-mark-as-shipped', ):
        return True

[1] https://hg.mozilla.org/projects/maple/file/tip/taskcluster/taskgraph/target_tasks.py#l410

Comment 3

[Rail Aliiev [:rail]]

We should also figure out how to switch between prod/dev ship-it URLs properly

Comment 4

[Aki Sasaki (not active)]

Looks like you figured this out, yay! We have logic in https://hg.mozilla.org/projects/maple/file/tip/taskcluster/taskgraph/util/scriptworker.py that does similar things for scopes; Callek suggested we move that to the kind.yml files, and I'm starting to agree. That's probably a separate non-blocker bug.

Comment 5

[Rail Aliiev [:rail]]

Attachment: bug1407637-mark-as-shipped.diff

* added a TODO to add deps
* added to target_tasks_publish_fennec()

Comment 6

[Rail Aliiev [:rail]]

Maple: https://hg.mozilla.org/projects/maple/rev/6b01f972ce6d5770003af775423d0f74ec52852b

Comment 7

[Rail Aliiev [:rail]]

This is on central now.