Closed Bug 140770 Opened 21 years ago Closed 21 years ago

Navigation doesn't work after creating a new bug

Categories

(Bugzilla :: Creating/Changing Bugs, defect, P1)

2.15

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: jouni, Assigned: gerv)

Details

Attachments

(1 file, 2 obsolete files)

post_bug.cgi doesn't seem to pass the bug_list parameter to the
created.html.tmpl template, so when navigate.html.tmpl is called in turn, a
warning about undefined bug_list.size is issued. I have a patch proposal,
attaching it soon.
Attached patch Patch proposal v1 (obsolete) — Splinter Review
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
Actually, it seems to me that navigation doesn't really make sense on that page.
The New and Query links are in the footer anyway, and you aren't in a train of
bugs at this point.

I counter-propose we remove the call to the navigate template from
created.html.tmpl.

Gerv
The current code will show you the first bug in the list, but I don't really
think that that is useful.

Hmm
Removing the use of navigate sounds right to me.  Who added it there?
Attached patch Patch v.2 (obsolete) — Splinter Review
Not sure. It is not there currently?

Anyway, patch to remove it.

Gerv
Attachment #81406 - Attachment is obsolete: true
Hmm yeah, you guys are right. The navigation should rather be removed. 

I still think the view after post_bug is not optimal (the lack of some sort of
navigation is nevertheless a problem in some situations), but I'll file another
bug with a decent proposal on that some day.
>I still think the view after post_bug is not optimal (the lack of some sort of
>navigation is nevertheless a problem in some situations), but I'll file another
>bug with a decent proposal on that some day.

I agree.  Users often want to do more with a bug once they file it, not to
mention assuring themselves that they filed the bug correctly, so we should show
them the bug they just filed.
Attached patch Patch v.3Splinter Review
This seems like the right thing to do.

Wow - the power of templates. A massive change like this is so little code...

Gerv
Attachment #81454 - Attachment is obsolete: true
OS: Windows 2000 → All
Hardware: PC → All
Comment on attachment 81555 [details] [diff] [review]
Patch v.3

Oooh, people are gonna love this one. :-)

r= justdave
Attachment #81555 - Flags: review+
Comment on attachment 81555 [details] [diff] [review]
Patch v.3

Looks good, and works for me. r=afranke
Attachment #81555 - Flags: review+
Fixed. Thanks, guys :-)

Checking in template/en/default/bug/create/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/created.html.tmpl,v
 <--  created.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/bug/process/results.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/results.html.tmpl,v
 <--  results.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.51; previous revision: 1.50
done

Gerv
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.