Navigation doesn't work after creating a new bug

RESOLVED FIXED in Bugzilla 2.16

Status

()

Bugzilla
Creating/Changing Bugs
P1
major
RESOLVED FIXED
16 years ago
5 years ago

People

(Reporter: Jouni Heikniemi, Assigned: gerv)

Tracking

2.15
Bugzilla 2.16

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

16 years ago
post_bug.cgi doesn't seem to pass the bug_list parameter to the
created.html.tmpl template, so when navigate.html.tmpl is called in turn, a
warning about undefined bug_list.size is issued. I have a patch proposal,
attaching it soon.
(Reporter)

Comment 1

16 years ago
Created attachment 81406 [details] [diff] [review]
Patch proposal v1

Updated

16 years ago
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
(Assignee)

Comment 2

16 years ago
Actually, it seems to me that navigation doesn't really make sense on that page.
The New and Query links are in the footer anyway, and you aren't in a train of
bugs at this point.

I counter-propose we remove the call to the navigate template from
created.html.tmpl.

Gerv
The current code will show you the first bug in the list, but I don't really
think that that is useful.

Hmm
Removing the use of navigate sounds right to me.  Who added it there?
(Assignee)

Comment 5

16 years ago
Created attachment 81454 [details] [diff] [review]
Patch v.2

Not sure. It is not there currently?

Anyway, patch to remove it.

Gerv
Attachment #81406 - Attachment is obsolete: true
(Reporter)

Comment 6

16 years ago
Hmm yeah, you guys are right. The navigation should rather be removed. 

I still think the view after post_bug is not optimal (the lack of some sort of
navigation is nevertheless a problem in some situations), but I'll file another
bug with a decent proposal on that some day.
>I still think the view after post_bug is not optimal (the lack of some sort of
>navigation is nevertheless a problem in some situations), but I'll file another
>bug with a decent proposal on that some day.

I agree.  Users often want to do more with a bug once they file it, not to
mention assuring themselves that they filed the bug correctly, so we should show
them the bug they just filed.
(Assignee)

Comment 8

16 years ago
Created attachment 81555 [details] [diff] [review]
Patch v.3

This seems like the right thing to do.

Wow - the power of templates. A massive change like this is so little code...

Gerv
Attachment #81454 - Attachment is obsolete: true
OS: Windows 2000 → All
Hardware: PC → All
Comment on attachment 81555 [details] [diff] [review]
Patch v.3

Oooh, people are gonna love this one. :-)

r= justdave
Attachment #81555 - Flags: review+
Comment on attachment 81555 [details] [diff] [review]
Patch v.3

Looks good, and works for me. r=afranke
Attachment #81555 - Flags: review+
(Assignee)

Comment 11

16 years ago
Fixed. Thanks, guys :-)

Checking in template/en/default/bug/create/created.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/created.html.tmpl,v
 <--  created.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/bug/process/results.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/results.html.tmpl,v
 <--  results.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.51; previous revision: 1.50
done

Gerv
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.