1407754 - Adding a toolbar item to the toolbar from Customize mode, and exiting Customize Mode quickly reverts the addition

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Enter Customize Mode
Right click on the Subscribe button
Choose "Add to Toolbar"
Immediately hit "Escape"

ER:
The Subscribe button should be in the toolbar

AR:
The Subscribe button isn't in the toolbar. Entering Customize mode again shows that it is still in the customization palette.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1407754 - exiting customize mode quickly after adding a toolbar item to toolbar properly adds it to the toolbar.

Review commit: https://reviewboard.mozilla.org/r/189146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189146/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8918340 [details]
Bug 1407754 - exiting customize mode quickly after adding a toolbar item to toolbar properly adds it to the toolbar.

https://reviewboard.mozilla.org/r/189146/#review194472

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfc7e5afb593
exiting customize mode quickly after adding a toolbar item to toolbar properly adds it to the toolbar. r=jaws

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cfc7e5afb593

Comment 5

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 58.0a1 (2017-10-11) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20171218174357
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0