1407769 - Add 'six' to test harness environments in CI

Status: RESOLVED INVALID

(Testing :: Mozbase, enhancement)

Description

[Andrew Halberstadt [:ahal]]

Enabling the py2/py3 compat linters on testing/mozbase and testing/mochitest required using the 'six' package. But this broke the test tasks that use mozbase (e.g mochitest, reftest) since six wasn't installed.

We'll either need to add six to the desktop-test images or get mozharness to install it.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

What about requiring six from within the global mozbase config file [1]? Or don't those other suites not require that file?

Btw what about other harnesses like Marionette? Do those work?


[1] https://dxr.mozilla.org/mozilla-central/source/testing/config/mozbase_requirements.txt

Comment 2

[Andrew Halberstadt [:ahal]]

That should work, we'd need to make sure 'six' gets packaged into the tests.zip at the right place, but this would be better than docker/pip because we'd be using the in-tree copy. Thanks, forgot about that file.

Comment 3

[Andrew Halberstadt [:ahal]]

This approach won't work because of bug 1297515. Pip 1.5 doesn't know how to install the 'six' wheel we have checked into the tree. So we can either block on that, or install it some other way, I guess by adding it to the internal pypi mirror.

Comment 4

[Andrew Halberstadt [:ahal]]

Dope, after all that it turns out six was already on the internal pypi mirror. I guess at least the version of pip being used got updated in the process.