1407842 - test_getUserMedia_basicScreenshare.html is going to permafail when Gecko 58 merges to Beta on 2017-11-02

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing test on the next merge day.

https://treeherder.mozilla.org/logviewer.html#?job_id=136357968&repo=try

TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html | Error executing test: TypeError: canvas.requestFullscreen is not a function @http://mochi.test:8888/tests/dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html:106:7 ... @http://mochi.test:8888/tests/dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html:100:11 ...

Applying the below patch locally should suffice for being able to reproduce it.
https://hg.mozilla.org/try/rev/eeae9ef12beb58a101757af1772a6b3215bdd534

Comment 1

[Andreas Pehrson [:pehrsons]]

Thanks Ryan. I'll take a look!

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1407842 - Wrap fullscreen api calls with SpecialPowers.

Review commit: https://reviewboard.mozilla.org/r/188690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188690/

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8917757 [details]
Bug 1407842 - Wrap fullscreen api calls with SpecialPowers.

Looks good on Try!

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8917757 [details]
Bug 1407842 - Wrap fullscreen api calls with SpecialPowers.

https://reviewboard.mozilla.org/r/188690/#review195620

lgtm

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b6b503cddf3
Wrap fullscreen api calls with SpecialPowers. r=jib

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5b6b503cddf3