Closed Bug 1407842 Opened 2 years ago Closed 2 years ago

test_getUserMedia_basicScreenshare.html is going to permafail when Gecko 58 merges to Beta on 2017-11-02

Categories

(Core :: WebRTC: Audio/Video, defect, P2, critical)

defect

Tracking

()

VERIFIED FIXED
mozilla58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 + verified

People

(Reporter: RyanVM, Assigned: pehrsons)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing test on the next merge day.

https://treeherder.mozilla.org/logviewer.html#?job_id=136357968&repo=try

TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html | Error executing test: TypeError: canvas.requestFullscreen is not a function @http://mochi.test:8888/tests/dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html:106:7 ... @http://mochi.test:8888/tests/dom/media/tests/mochitest/test_getUserMedia_basicScreenshare.html:100:11 ...

Applying the below patch locally should suffice for being able to reproduce it.
https://hg.mozilla.org/try/rev/eeae9ef12beb58a101757af1772a6b3215bdd534
Flags: needinfo?(apehrson)
Thanks Ryan. I'll take a look!
Assignee: nobody → apehrson
Status: NEW → ASSIGNED
Rank: 15
Flags: needinfo?(apehrson)
Priority: -- → P2
Comment on attachment 8917757 [details]
Bug 1407842 - Wrap fullscreen api calls with SpecialPowers.

Looks good on Try!
Attachment #8917757 - Flags: feedback+
Comment on attachment 8917757 [details]
Bug 1407842 - Wrap fullscreen api calls with SpecialPowers.

https://reviewboard.mozilla.org/r/188690/#review195620

lgtm
Attachment #8917757 - Flags: review?(jib) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5b6b503cddf3
Wrap fullscreen api calls with SpecialPowers. r=jib
https://hg.mozilla.org/mozilla-central/rev/5b6b503cddf3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.