1407843 - Remove nsICSSPseudoComparator and integrate the only instance into nsCSSRuleProcessor directly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

Using C++ comparator callback like nsICSSPseudoComparator makes it harder to implement related function in Servo side.

Given that nsTreeBodyFrame is the only implementation of nsICSSPseudoComparator, we should be able to remove this interface and simply pass a reference of the array down to XULTreeRuleProcessorData, and put the logic into nsCSSRuleProcessor directly.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1407843 part 1 - Introduce a global-level AtomArray type alias.

Review commit: https://reviewboard.mozilla.org/r/188968/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188968/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1407843 part 2 - Move tree pseudo matching code from nsTreeBodyFrame into nsCSSRuleProcessor.

Review commit: https://reviewboard.mozilla.org/r/188970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188970/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1407843 part 3 - Remove nsICSSPseudoComparator.

Review commit: https://reviewboard.mozilla.org/r/188972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188972/

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8918093 [details]
Bug 1407843 part 2 - Move tree pseudo matching code from nsTreeBodyFrame into nsCSSRuleProcessor.

https://reviewboard.mozilla.org/r/188970/#review194306

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8918094 [details]
Bug 1407843 part 3 - Remove nsICSSPseudoComparator.

https://reviewboard.mozilla.org/r/188972/#review194308

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8918092 [details]
Bug 1407843 part 1 - Introduce a global-level AtomArray type alias.

https://reviewboard.mozilla.org/r/188968/#review194480

::: xpcom/ds/AtomArray.h:11
(Diff revision 1)
> +
> +#ifndef mozilla_AtomArray_h
> +#define mozilla_AtomArray_h
> +
> +#include "mozilla/RefPtr.h"
> +#include "nsTArray.h"

Optional: including nsTArrayForwardDeclare.h here would work just as well, and might drag in less stuff.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e9d07abdc13
part 1 - Introduce a global-level AtomArray type alias. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/39713e51fe82
part 2 - Move tree pseudo matching code from nsTreeBodyFrame into nsCSSRuleProcessor. r=heycam
https://hg.mozilla.org/integration/autoland/rev/408f93434478
part 3 - Remove nsICSSPseudoComparator. r=heycam

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2e9d07abdc13
https://hg.mozilla.org/mozilla-central/rev/39713e51fe82
https://hg.mozilla.org/mozilla-central/rev/408f93434478