1407883 - Startup warning about app-system-defaults install location in xpcshell tests

Status: RESOLVED DUPLICATE of bug 144758

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Andrew Swan [:aswan]]

I'm seeing this warning during startup in some webextensions xpcshell tests.  It doesn't seem to affect the tests but it is noise that makes finding real failures in the logs harder.

 0:00.98 LOG: Thread-1 INFO "CONSOLE_MESSAGE: (info) 1507774031705      addons.xpi      WARN    Failed to add built-in install location app-system-defaults: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/FileUtils.jsm :: FileUtils_getDir :: line 64"  data: no] Stack trace: FileUtils_getDir()@resource://gre/modules/FileUtils.jsm:64 < addBuiltInInstallLocation()@resource://gre/modules/addons/XPIProvider.jsm:2039 < startup()@resource://gre/modules/addons/XPIProvider.jsm:2117 < callProvider()@resource://gre/modules/AddonManager.jsm:263 < _startProvider()@resource://gre/modules/AddonManager.jsm:730 < startup()@resource://gre/modules/AddonManager.jsm:897 < startup()@resource://gre/modules/AddonManager.jsm:3082 < observe()@addonManager.js:65 < promiseStartupManager()@resource://testing-common/AddonTestUtils.jsm:585"

Comment 1

[Robert Helmer [:rhelmer]]

I think we can avoid this by calling `overrideBuiltIns()` with an empty array in `head_addons.js`... this should cause xpcshell tests to not find any built-in add-ons.

Comment 2

[Andrew Swan [:aswan]]

Kris fixes this over in the duplicate