1407923 - (photon) Adjust light weight theme layout/color for Photon style

Status: VERIFIED FIXED

(Firefox for Android :: Theme and Visual Design, defect)

Description

[Jing-wei Wu [:jwu]]

Attachment: LWT_phone.png

We would like to adjust our LWT layout/color to be a little more Photon style, the attachment is the visual spec for mobile.

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: LWT_tablet.png

New LWT visual spec for tablet.

Comment 2

[Jing-wei Wu [:jwu]]

Attachment: Bug 1407923 - Adjust LWT layout/color for Photon style.

Review commit: https://reviewboard.mozilla.org/r/188644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188644/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8917721 [details]
Bug 1407923 - Adjust LWT layout/color for Photon style.

https://reviewboard.mozilla.org/r/188644/#review193922

Comment 4

[Jing-wei Wu [:jwu]]

Comment on attachment 8917721 [details]
Bug 1407923 - Adjust LWT layout/color for Photon style.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188644/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15a495497e3a
Adjust LWT layout/color for Photon style. r=nechen

Comment 6

[Jing-wei Wu [:jwu]]

Comment on attachment 8917721 [details]
Bug 1407923 - Adjust LWT layout/color for Photon style.

Approval Request Comment
[Feature/Bug causing the regression]:
Adjust LWT layout

[User impact if declined]:
The new Photon style sometimes doesn't have a clear visual with some LWTs, this is a visual enhancement as part of Photon related UI bug.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes, here is STR

1. Go to add-on page and install some LWTs
2. Make sure the layout and color of the URL bar is looked like the visual spec provided as attachments

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Most of the change are UI related and are for LWT used only. Also we have tried to keep the change as simple as possible.

[String changes made/needed]:
No

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8917721 [details]
Bug 1407923 - Adjust LWT layout/color for Photon style.

Fennec photon, Beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1b1762aecfb4

Comment 9

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/15a495497e3a

Comment 10

[Sorina Florean [:sflorean]]

Verified as fixed on 57 Beta 9.
Devices: Samsung Galaxy Tab 3 (Android 7.0) and Samsung Galaxy S8 (Android 7.).