Closed Bug 1407923 Opened 3 years ago Closed 3 years ago

(photon) Adjust light weight theme layout/color for Photon style

Categories

(Firefox for Android :: Theme and Visual Design, defect)

Unspecified
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox57 --- verified
firefox58 --- fixed

People

(Reporter: jwu, Assigned: jwu)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [FNC][SPT58.2][INT])

Attachments

(3 files)

Attached image LWT_phone.png
We would like to adjust our LWT layout/color to be a little more Photon style, the attachment is the visual spec for mobile.
Attached image LWT_tablet.png
New LWT visual spec for tablet.
Comment on attachment 8917721 [details]
Bug 1407923 - Adjust LWT layout/color for Photon style.

https://reviewboard.mozilla.org/r/188644/#review193922
Attachment #8917721 - Flags: review?(cnevinchen) → review+
Pushed by topwu.tw@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/15a495497e3a
Adjust LWT layout/color for Photon style. r=nechen
Comment on attachment 8917721 [details]
Bug 1407923 - Adjust LWT layout/color for Photon style.

Approval Request Comment
[Feature/Bug causing the regression]:
Adjust LWT layout

[User impact if declined]:
The new Photon style sometimes doesn't have a clear visual with some LWTs, this is a visual enhancement as part of Photon related UI bug.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes, here is STR

1. Go to add-on page and install some LWTs
2. Make sure the layout and color of the URL bar is looked like the visual spec provided as attachments

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Most of the change are UI related and are for LWT used only. Also we have tried to keep the change as simple as possible.

[String changes made/needed]:
No
Attachment #8917721 - Flags: approval-mozilla-beta?
Comment on attachment 8917721 [details]
Bug 1407923 - Adjust LWT layout/color for Photon style.

Fennec photon, Beta57+
Attachment #8917721 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/mozilla-central/rev/15a495497e3a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Verified as fixed on 57 Beta 9.
Devices: Samsung Galaxy Tab 3 (Android 7.0) and Samsung Galaxy S8 (Android 7.).
Whiteboard: [FNC][SPT58.2][INT]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.