1407953 - Fix dynamic change handling of XBL with quirks mode mismatches.

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See bug 1406875 comment 6 and bug 1406875 comment 11.

This landed yesterday in central, but we probably want to uplift it for 57.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Patch

Reviewed upstream, landed in autoland as https://hg.mozilla.org/integration/autoland/rev/7290aaeb8074.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8917761 [details] [review]
Patch

Approval Request Comment
[Feature/Bug causing the regression]: stylo
[User impact if declined]: video controls may not show up / react to user interaction in some edge cases like the ones described in bug 1405543
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: yes, see bug 1405543 comment 21 and bug 1405543 comment 25.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not risky
[Why is the change risky/not risky?]: the fix is actually a oneliner, that makes invalidation collection behave properly in this edge case that we found.
[String changes made/needed]: none

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Landed on central as https://hg.mozilla.org/mozilla-central/rev/7290aaeb8074.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8917761 [details] [review]
Patch

Recent regression, Stylo related, Beta57+

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Needs a rebased patch for Beta.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Rebased for beta.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8bdee6ba385a

Comment 8

[Oana Botisan, Desktop QA]

I managed to reproduce the bug using the steps from bug 1405543 comment 21 with an older version of Nightly (2017-10-09) on Windows 10x64 and Ubuntu 16.04x64. 
I retested everything using beta 57.0b8 and latest Nightly on the same platforms, but the bug is not reproducing anymore.