Open Bug 1407959 Opened 7 years ago Updated 2 years ago

stylo: Further optimize the custom property cycle removal to avoid name cloning

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- affected

People

(Reporter: xidorn, Unassigned)

References

Details

If we are going to take the patch in bug 1403839, we are going to do much more unnecessary atom cloning than necessary. They can be avoided by introducing a new wrapper type over HashMap and restrict operation on it to ensure that keys are never moved, and thus we can safely reference keys as soon as the wrapper type is still alive. It would require some unsafe code, but shouldn't be too terrible to audit.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.