1407969 - Update trace log code examples

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

We should update testing/geckodriver/doc/TraceLogs.md with the feedback from https://groups.google.com/forum/#!topic/selenium-developers/XTkDnZNhaWo.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1407969 - Organise code examples alphabetically.

Review commit: https://reviewboard.mozilla.org/r/188746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188746/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1407969 - Make Ruby example more ergonomic.

It is better in Ruby to explicitly set the client logger to a certain
level, than relying on the DEBUG output variable or the -d flag,
even though they are all equivalent.

Thanks-to: Lucas Tierney <[e-mail]>
Thanks-to: p0deje <[e-mail]>

Review commit: https://reviewboard.mozilla.org/r/188748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188748/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1407969 - Add C# code example.

Thanks-to: Jim Evans <[e-mail]>

Review commit: https://reviewboard.mozilla.org/r/188750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188750/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1407969 - Use FirefoxDriverLogLevel for Java example.

The Java client provides two setLogLevel methods in the
FirefoxOptions class.  It is recommended to use the one that accepts
FirefoxDriverLogLevel, as the other one is deprecated.

Thanks-to: Alexei Barantsev <[e-mail]>

Review commit: https://reviewboard.mozilla.org/r/188752/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188752/

Comment 5

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1407969 - TLSify Ruby docs links.

Review commit: https://reviewboard.mozilla.org/r/188754/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188754/

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8917800 [details]
Bug 1407969 - Organise code examples alphabetically.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188746/diff/1-2/

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8917801 [details]
Bug 1407969 - Make Ruby example more ergonomic.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188748/diff/1-2/

Comment 8

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8917802 [details]
Bug 1407969 - Add C# code example.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188750/diff/1-2/

Comment 9

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8917803 [details]
Bug 1407969 - Use FirefoxDriverLogLevel for Java example.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188752/diff/1-2/

Comment 10

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8917804 [details]
Bug 1407969 - TLSify Ruby docs links.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188754/diff/1-2/

Comment 11

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8917800 [details]
Bug 1407969 - Organise code examples alphabetically.

https://reviewboard.mozilla.org/r/188746/#review194066

Comment 12

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8917801 [details]
Bug 1407969 - Make Ruby example more ergonomic.

https://reviewboard.mozilla.org/r/188748/#review194068

Comment 13

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8917802 [details]
Bug 1407969 - Add C# code example.

https://reviewboard.mozilla.org/r/188750/#review194070

Comment 14

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8917803 [details]
Bug 1407969 - Use FirefoxDriverLogLevel for Java example.

https://reviewboard.mozilla.org/r/188752/#review194072

Comment 15

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8917804 [details]
Bug 1407969 - TLSify Ruby docs links.

https://reviewboard.mozilla.org/r/188754/#review194074

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bd61a29a8d6
Organise code examples alphabetically. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/06b1a22c5e62
Make Ruby example more ergonomic. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/6aff814fd34e
Add C# code example. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/c0319b345253
Use FirefoxDriverLogLevel for Java example. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/ee470df77e3f
TLSify Ruby docs links. r=maja_zf

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0bd61a29a8d6
https://hg.mozilla.org/mozilla-central/rev/06b1a22c5e62
https://hg.mozilla.org/mozilla-central/rev/6aff814fd34e
https://hg.mozilla.org/mozilla-central/rev/c0319b345253
https://hg.mozilla.org/mozilla-central/rev/ee470df77e3f