1408010 - Fallback to app chooser dialog when external protocol handler app not found

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P3)

Description

[Jan Horak [:jhorak]]

Follow-up from https://bugzilla.mozilla.org/show_bug.cgi?id=1297686#c68

Steps to reproduce:
1. install external protocol handler application for magnet scheme (like Transmission)
2. try to open magnet: protocol (for example from: https://www.openoffice.org/distribution/p2p/magnet.html )
3. pick the Transmission app as handler and check 'Remember my choice for magnet links'
4. uninstall Transmission app
5. try to open magnet link again
Result:
 Error page is shown because handler app was not found
Expected:
 Show user application chooser dialog in case the previously remembered application is not found.

Comment 1

[Jan Horak [:jhorak]]

Attachment: Bug 1408010 - Fallback to app chooser dialog when external handler app not found,

The nsExternalHelperAppService has been changed to ask for application in case
the preferred application has not been found (to cover the case the user has
uninstalled the application).

Review commit: https://reviewboard.mozilla.org/r/191092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191092/

Comment 2

[:Paolo Amadini]

Comment on attachment 8920087 [details]
Bug 1408010 - Fallback to app chooser dialog when external handler app not found,

https://reviewboard.mozilla.org/r/191092/#review197204

Thanks for the improvement!

::: commit-message-4494c:1
(Diff revision 1)
> +Bug 1408010 - Fallback to app chooser dialog when external handler app not found, r?[e-mail]

nit: just r=paolo in the commit message

Comment 3

[Jan Horak [:jhorak]]

Comment on attachment 8920087 [details]
Bug 1408010 - Fallback to app chooser dialog when external handler app not found,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191092/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f6a982100e9
Fallback to app chooser dialog when external handler app not found, r=Paolo

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9f6a982100e9