Closed
Bug 1408049
Opened 7 years ago
Closed 7 years ago
Remove an unneeded call to nsINode::IndexOf() from EditorBase::BeginningOfDocument()
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8917885 -
Flags: review?(masayuki)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8917885 [details] [diff] [review] Remove an unneeded call to nsINode::IndexOf() from EditorBase::BeginningOfDocument() Yeah, HTMLEditor overrides this method and doesn't call this (super class's) method. So, this must be safe.
Attachment #8917885 -
Flags: review?(masayuki) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c62bb9c6a8be Remove an unneeded call to nsINode::IndexOf() from EditorBase::BeginningOfDocument(); r=masayuki
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c62bb9c6a8be
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•