1408231 - Remove unnecessary forward declarations and add |static| where appropriate

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Description

[Nicholas Nethercote [inactive]]

This is possible now that all of libpref is in a single .cpp file.

For some functions, this required moving the comment from the forward
declaration to the definition.

MozReview-Commit-ID: 7XjHENZkc61

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove unnecessary forward declarations and add |static| where appropriate

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1408231 - Remove unnecessary forward declarations and add |static| where appropriate. .

This is possible now that all of libpref is in a single .cpp file.

For some functions, this required moving the comment from the forward
declaration to the definition.

Review commit: https://reviewboard.mozilla.org/r/188964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188964/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8918083 [details]
Bug 1408231 - Remove unnecessary forward declarations and add |static| where appropriate. .

https://reviewboard.mozilla.org/r/188964/#review194272

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfdd78172197790aae1fe8b307602e1a92f27072
Bug 1408231 - Remove unnecessary forward declarations and add |static| where appropriate. r=glandium.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bfdd78172197