Closed
Bug 1408275
Opened 8 years ago
Closed 8 years ago
Teach the write hazard analysis about more heap allocator functions
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
1.54 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
This bit me in bug 1407494 part 5 where I replaced some NS_strdup() calls with
moz_xstrdup(), and the former is in the ignore list but the latter isn't.
While I'm in there, might as well add a bunch of similar functions to avoid
other people hitting this problem in the future.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8918131 -
Flags: review?(sphink)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8918131 [details] [diff] [review]
Teach the write hazard analysis about more heap allocator functions
Review of attachment 8918131 [details] [diff] [review]:
-----------------------------------------------------------------
Sure, why not.
Attachment #8918131 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9cbfa157c86091d29d3e28bce623846c2001a35
Bug 1408275 - Teach the write hazard analysis about more heap allocator functions. r=sfink.
|
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•