1408277 - Add a toolchain job for clang 5.0

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1408277 - Add a toolchain job for clang 5.0.

Review commit: https://reviewboard.mozilla.org/r/188998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188998/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8918135 [details]
Bug 1408277 - Add a toolchain job for clang 5.0.

https://reviewboard.mozilla.org/r/188998/#review194484

::: taskcluster/ci/toolchain/linux.yml:15
(Diff revision 1)
>          symbol: TL(clang3.9)
>          tier: 1
>      worker-type: aws-provisioner-v1/gecko-{level}-b-linux
>      worker:
>          docker-image: {in-tree: desktop-build}
> -        max-run-time: 36000
> +        max-run-time: 7200

Hm, ten hours probably *was* a little excessive, wasn't it....

::: taskcluster/scripts/misc/build-clang-5-linux.sh:19
(Diff revision 1)
> +# gets a bit too verbose here
> +set +x
> +
> +cd build/build-clang
> +# |mach python| sets up a virtualenv for us!
> +../../mach python ./build-clang.py -c clang-5-linux64.json

It would be nice if we stopped having to write all these scripts for clang and were able to specify the JSON config somewhere in the toolchain task.  Is that even feasible?

Comment 3

[(not currently active) Ted Mielczarek]

The toolchain task schema has an `arguments` field:
https://dxr.mozilla.org/mozilla-central/rev/196dadb2fe500e75c6fbddcac78106648676cf10/taskcluster/taskgraph/transforms/job/toolchain.py#40

Seems like we could just have a `build-clang-linux.sh` and pass the JSON file in as an argument.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a01135b451a4
Add a toolchain job for clang 5.0. r=froydnj

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8918135 [details]
Bug 1408277 - Add a toolchain job for clang 5.0.

https://reviewboard.mozilla.org/r/188998/#review194484

> It would be nice if we stopped having to write all these scripts for clang and were able to specify the JSON config somewhere in the toolchain task.  Is that even feasible?

I think we need to change how the toolchains are declared, making them less repetitive in the yaml. Surely, we can improve the situation for scripts as well.

Relatedly, yesterday, there was an outage of the svn repo on llvm.org, which made me think we maybe really should have an additional "layer" of source downloading jobs.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a01135b451a4