1408319 - Build for UITests schema is not built in BB due to a compilation error

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Isabel Rios[:isabel_rios]]

The build for UITests schema is not build and so the UI tests are not running.

There is a compilation error: 

UITests/BookmarksPanelTests.swift:[46,70] missing argument for parameter 'dateAdded' in call

BookmarkMirrorItem.folder(BookmarkRoots.ToolbarFolderGUID, modified: bufferDate, hasDupe: false, parentID: BookmarkRoots.RootGUID, parentName: nil, title: "Bookmarks Toolbar", description: nil, children: ["aaa", "bbb"]),

UITests/BookmarksPanelTests.swift:[87,48] missing argument for parameter 'dateAdded' in call
4709
    »         return BookmarkMirrorItem.bookmark(guid, modified: Date.now(), hasDupe: false, parentID: parentID, parentName: nil, title: title, description: nil, URI: "http://unused.com", tags: "[]", keyword: nil)

UITests/BookmarksPanelTests.swift:[91,46] missing argument for parameter 'dateAdded' in call
4715
    »         return BookmarkMirrorItem.folder(guid, modified: Date.now(), hasDupe: false, parentID: parentID, parentName: nil, title: title, description: nil, children: childrenGuids)

Comment 1

[Isabel Rios[:isabel_rios]]

The build for UITests schema is still failing. Seems that the BookmarksPanel tests are fine, but there are a bunch of others that are failing, please check the logs:

https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/59e6a79787b7920001a31a30#logs

I already asked BB to update to latest carthage version, but not sure that is the cause of all failures.
Usha, could you please take a look? Thanks!

Comment 2

[No-Jun Park [:njpark]]

Looking at the logs, it looks like it compiles fine now after the BookmarksPanel tests, but now we have to deal with a bunch of failed tests.  We should file a new bug for each failed tests, and reference it here.  BB has a tendency to show 'Build Failed' message and not show the number of failed tests, if there are too many of them.

Comment 3

[Isabel Rios[:isabel_rios]]

I got a reply about Carthage. Carthage 0.26.2 is available on buddybuild. You can select it if you go into App Settings > Environment and select it from here. 
We can try to run the UITests with that update to see if there are changes in the results.

Agree on filing different bugs per Test Suite where there are failed tests.