Closed Bug 1408366 Opened 6 years ago Closed 6 years ago

U+034F COMBINING GRAPHEME JOINER breaks shaping in some fonts

Categories

(Core :: Layout: Text and Fonts, enhancement)

Product:
Core
Component:
Layout: Text and Fonts
Version:
52 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: dr.khaled.hosny, Assigned: jfkthame)

References

Details

Attachments

(3 files)

Test case rendered in Firefox
12.68 KB, image/png
Details
Test case rendered in Chrome
8.69 KB, image/png
Details
Unicode combining grapheme joiner (U+034F) should not break the font run
1.13 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
It seems that if a font lacks a glyph for U+034F COMBINING GRAPHEME JOINER, Firefox will fallback to a different font and break shaping, but this fallback is unnecessary since HarfBuzz will deal with it just fine.

Test case:
data:text/html;charset=utf8,<p style="font: 100pt Amiri">ىٕ͏ِد</p>

The fonts tab in the developer tools shows that Amiri and another font are used.

    
  
See Also:  → https://github.com/w3c/alreq/issues/147

    
    

    
  
Makes sense; we already deal with certain other control characters in this way, allowing them in the run regardless of whether the font explicitly supports them. We should just treat CGJ the same.

    
  
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED

        Attachment #8918301 -
        Flags: review?(jmuizelaar) → review+

    
    

    
  
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f55f929971
Unicode combining grapheme joiner (U+034F) should not break the font run. r=jrmuizel

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b6f55f929971
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox58:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

          You need to log in
          before you can comment on or make changes to this bug.