1408368 - [dt-onboarding] Move aboutdevtools.dtd out of locales folder until ready for localization

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

aboutdevtools.dtd is missing comments and might also change significantly while we work on follow ups to Bug 1361080.

Move this file out of devtools/shim/locales/en-US so that localization tools won't pick it up.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1408368 - move aboutdevtools.dtd out of localized folder;

Review commit: https://reviewboard.mozilla.org/r/189106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189106/

Comment 2

[Julian Descottes [:jdescottes]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea7fbbf1dc0aec98aae0427a42164a02d16f7d92

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8918258 [details]
Bug 1408368 - move aboutdevtools.dtd out of localized folder;

https://reviewboard.mozilla.org/r/189106/#review194428

Looks good to me

::: devtools/shim/jar.mn:13
(Diff revision 1)
>      content/aboutdevtools/aboutdevtools.css (aboutdevtools/aboutdevtools.css)
>      content/aboutdevtools/aboutdevtools.js (aboutdevtools/aboutdevtools.js)
>  
>      content/aboutdevtools/images/otter.png (aboutdevtools/images/otter.png)
>  
> +    # Temporary localisation file, move back to devtools/shim/locales/en-US when ready for localization

Do we have a bug for that ? It would be nice to refer to it here if we do.

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8918258 [details]
Bug 1408368 - move aboutdevtools.dtd out of localized folder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189106/diff/1-2/

Comment 5

[Julian Descottes [:jdescottes]]

Thanks for the review Nicolas. 
> Do we have a bug for that ? It would be nice to refer to it here if we do.
Good point I'll log a follow up and update the comment.

Pike: the goal of this change is to avoid aboutdevtools.dtd being picked up by l10n tools (see summary). Can you confirm moving it to a non-locales folder will do the trick? 

Thanks!

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 8918258 [details]
Bug 1408368 - move aboutdevtools.dtd out of localized folder;

https://reviewboard.mozilla.org/r/189106/#review194430

Yeah, this should work.

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 8918258 [details]
Bug 1408368 - move aboutdevtools.dtd out of localized folder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189106/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6a234f1453e
move aboutdevtools.dtd out of localized folder;r=nchevobbe,Pike

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c6a234f1453e