[dt-onboarding] Move aboutdevtools.dtd out of locales folder until ready for localization

RESOLVED FIXED in Firefox 58

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

unspecified
Firefox 58
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

aboutdevtools.dtd is missing comments and might also change significantly while we work on follow ups to Bug 1361080.

Move this file out of devtools/shim/locales/en-US so that localization tools won't pick it up.
Comment on attachment 8918258 [details]
Bug 1408368 - move aboutdevtools.dtd out of localized folder;

https://reviewboard.mozilla.org/r/189106/#review194428

Looks good to me

::: devtools/shim/jar.mn:13
(Diff revision 1)
>      content/aboutdevtools/aboutdevtools.css (aboutdevtools/aboutdevtools.css)
>      content/aboutdevtools/aboutdevtools.js (aboutdevtools/aboutdevtools.js)
>  
>      content/aboutdevtools/images/otter.png (aboutdevtools/images/otter.png)
>  
> +    # Temporary localisation file, move back to devtools/shim/locales/en-US when ready for localization

Do we have a bug for that ? It would be nice to refer to it here if we do.
Attachment #8918258 - Flags: review?(nchevobbe) → review+
Thanks for the review Nicolas. 
> Do we have a bug for that ? It would be nice to refer to it here if we do.
Good point I'll log a follow up and update the comment.

Pike: the goal of this change is to avoid aboutdevtools.dtd being picked up by l10n tools (see summary). Can you confirm moving it to a non-locales folder will do the trick? 

Thanks!
Blocks: 1408369
Comment on attachment 8918258 [details]
Bug 1408368 - move aboutdevtools.dtd out of localized folder;

https://reviewboard.mozilla.org/r/189106/#review194430

Yeah, this should work.
Attachment #8918258 - Flags: review?(l10n) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6a234f1453e
move aboutdevtools.dtd out of localized folder;r=nchevobbe,Pike
https://hg.mozilla.org/mozilla-central/rev/c6a234f1453e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.