1408431 - Incorrect trace symbol for Ruby code example in doc/TraceLogs.md

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

From Lucas:

> It looks like the change you submitted used :trace for the
> selenium logger, it needs to be :debug as the selenium logger does
> not have a :trace severity.
>
>> Selenium::WebDriver.logger.level = :debug

Comment 1

[Andreas Tolfsen ❲:ato❳]

As I understand it, the argument to Selenium::WebDriver.logger.level
should be :debug, but the argument to
Selenium::WebDriver::Firefox::Options.new should be :trace.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1408431 - Fix symbol for Selenium logger in Ruby example.

DONTBUILD

Thanks-to: Lucas Tierney <[e-mail]>

Review commit: https://reviewboard.mozilla.org/r/189142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189142/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lukas mind having a look and tell us if that is the correct approach now?

Comment 4

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #3)
> Lukas mind having a look and tell us if that is the correct approach now?

That is a quote by Lucas in https://bugzilla.mozilla.org/show_bug.cgi?id=1408431#c0.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please see your comment 1. You are not sure about the correct level for Options.new.

Comment 6

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #5)

> Please see your comment 1. You are not sure about the correct
> level for Options.new.

I trust the maintainer of the Ruby client to give me the correct
information.

Here is a link to the source code for you:

	https://github.com/SeleniumHQ/selenium/blob/master/rb/lib/selenium/webdriver/common/logger.rb

Comment 7

[lucast1533]

The updated code is correct


    Selenium::WebDriver.logger.level = :debug
    opts = Selenium::WebDriver::Firefox::Options.new(log_level: :trace)
    driver = Selenium::WebDriver.for :firefox, options: opts

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8918339 [details]
Bug 1408431 - Fix symbol for Selenium logger in Ruby example.

https://reviewboard.mozilla.org/r/189142/#review194842

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff75e9a66058
Fix symbol for Selenium logger in Ruby example. r=whimboo

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ff75e9a66058