Closed
Bug 1408431
Opened 7 years ago
Closed 7 years ago
Incorrect trace symbol for Ruby code example in doc/TraceLogs.md
Categories
(Testing :: geckodriver, enhancement)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(1 file)
From Lucas: > It looks like the change you submitted used :trace for the > selenium logger, it needs to be :debug as the selenium logger does > not have a :trace severity. > >> Selenium::WebDriver.logger.level = :debug
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
As I understand it, the argument to Selenium::WebDriver.logger.level should be :debug, but the argument to Selenium::WebDriver::Firefox::Options.new should be :trace.
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
Lukas mind having a look and tell us if that is the correct approach now?
Flags: needinfo?(lucast1533)
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #3) > Lukas mind having a look and tell us if that is the correct approach now? That is a quote by Lucas in https://bugzilla.mozilla.org/show_bug.cgi?id=1408431#c0.
Flags: needinfo?(lucast1533)
Comment 5•7 years ago
|
||
Please see your comment 1. You are not sure about the correct level for Options.new.
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #5) > Please see your comment 1. You are not sure about the correct > level for Options.new. I trust the maintainer of the Ruby client to give me the correct information. Here is a link to the source code for you: https://github.com/SeleniumHQ/selenium/blob/master/rb/lib/selenium/webdriver/common/logger.rb
Comment 7•7 years ago
|
||
The updated code is correct Selenium::WebDriver.logger.level = :debug opts = Selenium::WebDriver::Firefox::Options.new(log_level: :trace) driver = Selenium::WebDriver.for :firefox, options: opts
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8918339 [details] Bug 1408431 - Fix symbol for Selenium logger in Ruby example. https://reviewboard.mozilla.org/r/189142/#review194842
Attachment #8918339 -
Flags: review?(hskupin) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff75e9a66058 Fix symbol for Selenium logger in Ruby example. r=whimboo
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ff75e9a66058
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•