1408582 - Android builds are going to permafail when Gecko 58 merges to Beta on 2017-11-02

Status: VERIFIED FIXED

(Core :: WebRTC, defect, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Busted Android builds on the next merge day.

https://treeherder.mozilla.org/logviewer.html#?job_id=136933745&repo=try

/builds/worker/workspace/build/src/media/webrtc/signaling/src/common/browser_logging/CSFLog.cpp:85:21: error: unused variable 'level' [-Werror=unused-variable]

Patch below should suffice to reproduce locally:
https://hg.mozilla.org/try/rev/a9418c4ef938b9c693f792bddbe1885129c6ed6e

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1408582 - Fix unused variable warning in CSFLog.cpp on Android;

Review commit: https://reviewboard.mozilla.org/r/189832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189832/

Comment 2

[Dan Minor [:dminor]]

Ryan, do you mind checking that this fixes the problem? I wasn't able to easily get a build with the patch you supplied.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8918932 [details]
Bug 1408582 - Fix unused variable warning in CSFLog.cpp on Android;

Works great, thanks!

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8918932 [details]
Bug 1408582 - Fix unused variable warning in CSFLog.cpp on Android;

https://reviewboard.mozilla.org/r/189832/#review196112

LGTM

Note: this is going to cause a merge conflict with the other patch over in bug 1402334 which I just r+.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3db1a494406d
Fix unused variable warning in CSFLog.cpp on Android; r=drno

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3db1a494406d