1408643 - Message about missing Proguard JAR tells you wrong command to fix the issue

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Jan Henning [:JanH]]

The message says
> ERROR: proguard.jar 5.3.3 or higher is required (looked for /home/jan/.mozbuild/proguard/lib/proguard.jar). Run |mach artifact install --from-build proguard-jar| or add `export PROGUARD_JAR=/path/to/proguard.jar` to your mozconfig.

but then attempting to actually run |mach artifact install --from-build proguard-jar| errors out with
> It looks like you passed an unrecognized argument into mach.
> 
> The artifact command does not accept the arguments: --from-build

I suppose this needs updating to reference |./mach artifact toolchain -v --from-build proguard-jar| instead?

Comment 2

[Nick Alexander :nalexander [he/him]]

This message just needs to be updated at http://searchfox.org/mozilla-central/source/build/moz.configure/java.configure#98.  The real issue is that |mach artifact toolchain| doesn't install into ~/.mozbuild, since automation wants things in $topsrcdir.  So one needs to do |cd ~/.mozbuild && /PATH/TO/mach artifact toolchain|, which sucks.  I'd rather add a --cwd flag to |mach artifact toolchain| to avoid needing to figure out the /PATH/TO for the help message.

Comment 4

[Teng-pao Yu [:tyu]]

Just stepped into this. It's still `run |mach artifact install --from-build proguard-jar|` now.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I'll try to clean this up a bit.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1408643 - Fix up Proguard install command from configure.

Review commit: https://reviewboard.mozilla.org/r/217516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217516/

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8947828 [details]
Bug 1408643 - Fix up Proguard install command from configure.

https://reviewboard.mozilla.org/r/217516/#review223358

Thank you, sir!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b7ef7afd156
Fix up Proguard install command from configure. r=nalexander

Comment 9

[Andreea Pavel [:apavel]]

Backed out for failing flake8 at /builds/worker/checkouts/gecko/build/moz.configure/java.configure:98:100

push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3b7ef7afd156458e6cb2506840c575c1fa42a8ef

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=160153150&repo=autoland&lineNumber=245

Backout: https://hg.mozilla.org/integration/autoland/rev/1eacd71939cbf4316d6cb25ccff41d1be12cfd8c

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8947828 [details]
Bug 1408643 - Fix up Proguard install command from configure.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217516/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcebc8274aea
Fix up Proguard install command from configure. r=nalexander

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bcebc8274aea