Open Bug 1408690 Opened 7 years ago Updated 7 months ago

webrender border-images code never actually runs

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: Gankra, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [wr-reserve] [gfx-noted])

There's currently a check of the form if (type != image || type != gradient) { return; } which is always false. Found this while refactoring and fixed it locally, but it looks like the gradient code is buggy, fails a lot of tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=99f43c4d0b828a07f39c550db14cadd5e03f4b0d&selectedJob=136895315
Summary: border-images code never actually runs → webrender border-images code never actually runs
Whiteboard: [wr-mvp] [triage]
Priority: P3 → P2
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
I'm going to land a refactor of this code that indicates that these are explicitly disabled because they're broken. Gradients are probably blocked on implementing this API upstream: https://github.com/servo/webrender/issues/1875#issuecomment-336680053 Not sure why images aren't working; don't know anything about that subsystem so I'm probably not the best person to look at this.
Depends on: 1409773
Depends on: 1409774
Whiteboard: [wr-mvp] → [wr-mvp][gfx-noted]
Priority: P2 → P3
Whiteboard: [wr-mvp][gfx-noted] → [wr-reserve] [gfx-noted]
I haven't seen any indication that we'll need this for the MVP. If we do we can block on it.
No longer blocks: stage-wr-nightly
Blocks: stage-wr-backlog
Depends on: 1488457
No longer blocks: 1556243
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.