Closed Bug 1408736 Opened 5 years ago Closed 5 years ago

[macOS] [Photon] [Polishing] The Private Window Icon could be placed 1px more to the right to be aligned with the Toolbar Menu icon

Categories

(Firefox :: Theme, defect, P1)

Unspecified
macOS
defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox58 --- verified

People

(Reporter: mehmet.sahin, Assigned: daleharvey)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(3 files)

Attached image actual.png
macOS 10.12.6
58.0a1 (2017-10-14) (64-Bit)

STR:

1.) Open a Private Window
2.) Take a look at the Private Window Icon at the ride side in the Tab Strip
3.) Compare the position of the Private Window Icon with the position of the Menu Icon in the Toolbar

Expected: The Private Window Icon could be placed 1px more to the right to be aligned with the Toolbar Menu icon

Actual: The Private Window Icon is 1px too far left.
Attached image expected.png
Whiteboard: [photon-visual][triage]
Priority: -- → P4
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Assignee: nobody → dharvey
Blocks: 1407185
Status: NEW → ASSIGNED
Priority: P4 → P1
This isnt affected by the other bug, in private browsing mode we have toolbar-fullscreen-button instead of the titlebar-placeholder
No longer blocks: 1407185
So this only effects this and the accessibility indicator, it looks very subtly neater and is fairly isolated, but its very minor so I think it would be ok to WONTFIX if there are problems with changing the margin here
Comment on attachment 8919680 [details]
Bug 1408736 - Align private browing with toolbar.

https://reviewboard.mozilla.org/r/190592/#review196268
Attachment #8919680 - Flags: review?(dao+bmo) → review+
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c35fd34277c
Align private browing with toolbar. r=dao
https://hg.mozilla.org/mozilla-central/rev/2c35fd34277c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
I tested this on Mac OS X 10.12 with FF Nightly 58.0a1(2017-11-02) and I can confirm the fix.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.