Closed Bug 1408736 Opened 5 years ago Closed 5 years ago
OS] [Photon] [Polishing] The Private Window Icon could be placed 1px more to the right to be aligned with the Toolbar Menu icon
macOS 10.12.6 58.0a1 (2017-10-14) (64-Bit) STR: 1.) Open a Private Window 2.) Take a look at the Private Window Icon at the ride side in the Tab Strip 3.) Compare the position of the Private Window Icon with the position of the Menu Icon in the Toolbar Expected: The Private Window Icon could be placed 1px more to the right to be aligned with the Toolbar Menu icon Actual: The Private Window Icon is 1px too far left.
Priority: -- → P4
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
This isnt affected by the other bug, in private browsing mode we have toolbar-fullscreen-button instead of the titlebar-placeholder
No longer blocks: 1407185
So this only effects this and the accessibility indicator, it looks very subtly neater and is fairly isolated, but its very minor so I think it would be ok to WONTFIX if there are problems with changing the margin here
Comment on attachment 8919680 [details] Bug 1408736 - Align private browing with toolbar. https://reviewboard.mozilla.org/r/190592/#review196268
Attachment #8919680 - Flags: review?(dao+bmo) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/2c35fd34277c Align private browing with toolbar. r=dao
I tested this on Mac OS X 10.12 with FF Nightly 58.0a1(2017-11-02) and I can confirm the fix.
You need to log in before you can comment on or make changes to this bug.