Closed
Bug 1408767
Opened 7 years ago
Closed 7 years ago
HTMLEditor::MouseMove: unused variables
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In file included from /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/editor/libeditor/Unified_cpp_editor_libeditor1.cpp:56:
/data/jenkins/workspace/firefox-clang-last/editor/libeditor/HTMLEditorObjectResizer.cpp:823:27: error: unused variable 'leftStr' [-Werror,-Wunused-variable]
NS_NAMED_LITERAL_STRING(leftStr, "left");
^
/data/jenkins/workspace/firefox-clang-last/editor/libeditor/HTMLEditorObjectResizer.cpp:824:27: error: unused variable 'topStr' [-Werror,-Wunused-variable]
NS_NAMED_LITERAL_STRING(topStr, "top");
This is because clang improved its detection of unused variables: https://reviews.llvm.org/D38678
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8918664 [details] Bug 1408767 - HTMLEditor::MouseMove: Remove two unused variables https://reviewboard.mozilla.org/r/189496/#review194680
Attachment #8918664 -
Flags: review?(m_kato) → review+
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f10456d052a HTMLEditor::MouseMove: Remove two unused variables r=m_kato
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7f10456d052a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•