Closed
Bug 1408777
Opened 7 years ago
Closed 7 years ago
Automatically fix instances of missing semicolons in the tree.
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P2)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: dbugs, Assigned: dbugs)
References
Details
Attachments
(1 file, 2 obsolete files)
|
1.15 MB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
In bug 1367704 we are enabling the eslint semi rule. As it is the weekend and the patch isn't fully ready yet, we are landing automatic fixes today if all goes well.
We'll then complete bug 1367704 sometime this next week.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8918667 -
Flags: review?(standard8)
|
||
Comment 2•7 years ago
|
||
Slightly updated patch to drop the browser/components/migration changes to avoid ESLint failures with the current tree status.
Try push here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fbb2145f06039af58fd791bc92ecf56177b569a
Attachment #8918667 -
Attachment is obsolete: true
Attachment #8918667 -
Flags: review?(standard8)
Attachment #8918669 -
Flags: review?(standard8)
|
|
||
Comment 3•7 years ago
|
||
Fixes a small test failure. I've looked through the patch and it seems fine.
Attachment #8918669 -
Attachment is obsolete: true
Attachment #8918669 -
Flags: review?(standard8)
Attachment #8918682 -
Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/167e5e6fd930
Automatically fix instances of missing semicolons in the tree. r=Standard8
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
Product: Testing → Firefox Build System
|
||
Updated•6 years ago
|
Version: Version 3 → 3 Branch
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•