Automatically fix instances of missing semicolons in the tree.

RESOLVED FIXED in Firefox 58

Status

enhancement
P2
normal
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: dbugs, Assigned: dbugs)

Tracking

3 Branch
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

2 years ago
In bug 1367704 we are enabling the eslint semi rule. As it is the weekend and the patch isn't fully ready yet, we are landing automatic fixes today if all goes well.

We'll then complete bug 1367704 sometime this next week.
Assignee

Comment 1

2 years ago
Posted patch Automatic fixes (obsolete) — Splinter Review
Attachment #8918667 - Flags: review?(standard8)
Posted patch Automatic fixes updated (obsolete) — Splinter Review
Slightly updated patch to drop the browser/components/migration changes to avoid ESLint failures with the current tree status.

Try push here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fbb2145f06039af58fd791bc92ecf56177b569a
Attachment #8918667 - Attachment is obsolete: true
Attachment #8918667 - Flags: review?(standard8)
Attachment #8918669 - Flags: review?(standard8)
Fixes a small test failure. I've looked through the patch and it seems fine.
Attachment #8918669 - Attachment is obsolete: true
Attachment #8918669 - Flags: review?(standard8)
Attachment #8918682 - Flags: review+

Comment 4

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/167e5e6fd930
Automatically fix instances of missing semicolons in the tree. r=Standard8
https://hg.mozilla.org/mozilla-central/rev/167e5e6fd930
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

Updated

a year ago
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.