1408795 - Various fixes for the project generated by the CppEclipse backend

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1408795 - Turn off Eclipse CDT's "Ensure newline at the end of file" setting.

The setting to ensure that there is a newline at the end of files when they
are saved is very annoying.  Besides adding unnecessary and unexpected cruft
to diffs, some parts of the codebase (some of the reftest directories for
example) have a policy of NOT having a newline at the end of their files.

Review commit: https://reviewboard.mozilla.org/r/189722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189722/

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1408795 - Prevent Eclipse CDT's blocking "Welcome" screen from showing on startup.

The blocking Welcome screen is quite confusing for a new user. It is not clear
where to find the Mozilla stuff they expect to see when opening Eclipse, or
that the user needs to close the entire content area to get to it. Besides that
the screen isn't very useful for Mozilla people who will find more relevant
help from searching the online documentation, and who won't be creating new
projects in the generated workspace, etc.

Review commit: https://reviewboard.mozilla.org/r/189724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189724/

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1408795 - Enable Eclipse CDT's "Refresh using native hooks or polling" setting.

This setting allows Eclipse to notice when files it has open are changed
externally (such as by hg/git, for example).  It can then update the contents
that it has for the open files, avoiding annoying issues such as saving changes
after an `hg pull -u` resulting in either "Resource is out of sync" errors or
else clobbering of the changes hg made to files.

Review commit: https://reviewboard.mozilla.org/r/189726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189726/

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: Bug 1408795 - Have Eclipse CDT treat Objective-C files as C++.

Without this setting, eclipse will refuse to open Objective-C files (it will
defer to an external editor).  Adding *.mm to the file types that are treated
as C++ allows Eclipse to open them, and to provide some code assistance for
the bits of the files that it can understand.

Review commit: https://reviewboard.mozilla.org/r/189728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189728/

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: Bug 1408795 - Disable Eclipse CDT's "scalability" mode for files with fewer than 15,000 lines.

By default, scalability mode is activated for files with 5,000 lines or more.
There are quite a few C++ files with more than 5,000 lines, and Eclipse seems
to work fine with them with scalability mode turned off (even
nsCSSFrameConstructor.cpp which is over 13,000 lines long).  Increasing the
number of lines before scalability mode is enabled allows Eclipse to handle
these files better.

Review commit: https://reviewboard.mozilla.org/r/189730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189730/

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: Bug 1408795 - Disable Eclipse CDT's binary parser.

By default Eclipse CDT will scan the source tree for binaries so that it can
add those binaries to the list of things that it can run.  This scanning is a
constant interuption and can last several seconds.  Besides that, it's
currently useless for our setup since the only binaries that we're interested
in running are in the object directory (which it doesn't scan), and those are
set up during project generation.  (The only binaries found in the source tree
are a couple of uninteresting bundled libraries.)

Review commit: https://reviewboard.mozilla.org/r/189732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189732/

Comment 7

[Botond Ballo [:botond]]

Comment on attachment 8918864 [details]
Bug 1408795 - Turn off Eclipse CDT's "Ensure newline at the end of file" setting.

https://reviewboard.mozilla.org/r/189722/#review194982

Comment 8

[Botond Ballo [:botond]]

Comment on attachment 8918865 [details]
Bug 1408795 - Prevent Eclipse CDT's blocking "Welcome" screen from showing on startup.

https://reviewboard.mozilla.org/r/189724/#review194984

Comment 9

[Botond Ballo [:botond]]

Comment on attachment 8918866 [details]
Bug 1408795 - Enable Eclipse CDT's "Refresh using native hooks or polling" setting.

https://reviewboard.mozilla.org/r/189726/#review194986

Comment 10

[Botond Ballo [:botond]]

Comment on attachment 8918867 [details]
Bug 1408795 - Have Eclipse CDT treat Objective-C files as C++.

https://reviewboard.mozilla.org/r/189728/#review194988

Comment 11

[Botond Ballo [:botond]]

Comment on attachment 8918868 [details]
Bug 1408795 - Disable Eclipse CDT's "scalability" mode for files with fewer than 15,000 lines.

https://reviewboard.mozilla.org/r/189730/#review194992

Comment 12

[Botond Ballo [:botond]]

Comment on attachment 8918869 [details]
Bug 1408795 - Disable Eclipse CDT's binary parser.

https://reviewboard.mozilla.org/r/189732/#review194996

Comment 13

[Botond Ballo [:botond]]

I think these are all reasonable and useful settings changes - thanks!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8a0df0c0f15
Turn off Eclipse CDT's "Ensure newline at the end of file" setting. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca1b05539acc
Prevent Eclipse CDT's blocking "Welcome" screen from showing on startup. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7d702f83a7d
Enable Eclipse CDT's "Refresh using native hooks or polling" setting. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf4442765b3e
Have Eclipse CDT treat Objective-C files as C++. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/c356621eb568
Disable Eclipse CDT's "scalability" mode for files with fewer than 15,000 lines. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa3b65ce1dc0
Disable Eclipse CDT's binary parser. r=botond DONTBUILD NPOTB

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c8a0df0c0f15
https://hg.mozilla.org/mozilla-central/rev/ca1b05539acc
https://hg.mozilla.org/mozilla-central/rev/a7d702f83a7d
https://hg.mozilla.org/mozilla-central/rev/bf4442765b3e
https://hg.mozilla.org/mozilla-central/rev/c356621eb568
https://hg.mozilla.org/mozilla-central/rev/fa3b65ce1dc0