1408927 - Enable browser_webconsole_closing_after_completion.js in the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1408927 - Enable browser_webconsole_closing_after_completion.js in the new console frontend; .

Review commit: https://reviewboard.mozilla.org/r/199702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199702/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8928445 [details]
Bug 1408927 - Enable browser_webconsole_closing_after_completion.js in the new console frontend; .

https://reviewboard.mozilla.org/r/199702/#review204792

The migration looks good, but the test is not doing what its name says. There is no "completion" in the test. So I did a bit of archeology :)

I traced back the origin of the test and it comes from https://hg.mozilla.org/mozilla-central/rev/aff7615b9d2c
A lot of hud tests were mixed into this huge test: https://hg.mozilla.org/mozilla-central/file/aff7615b9d2c/toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js
"webconsole_closing_after_completion" was called testWebConsoleClose().
At that time, our test was run at the end of another test: testErrorOnPageReload(). 
testErrorOnPageReload() has then been migrated to "browser_webconsole_bug_580030_errors_after_page_reload" and the two tests were separated.

So, I am not sure this test is actually relevant without being run after "errors_after_page_reload". I think we should at least update the comments and name of the test to stick to the reality (=> no errors when closing the console). And maybe file a follow up to improve "errors_after_page_reload" and test what used to be tested?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Thanks for the review and the digging !
I'd rather fix this test and try to do completion in this test as well.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8928445 [details]
Bug 1408927 - Enable browser_webconsole_closing_after_completion.js in the new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199702/diff/1-2/

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Added a completion before closing, since it seemed to be what was failing originally.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9c6e46ba1cc
Enable browser_webconsole_closing_after_completion.js in the new console frontend; r=jdescottes.

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b9c6e46ba1cc