Closed Bug 1408932 Opened 3 years ago Closed 3 years ago

Enable browser_webconsole_cspro.js in the new console frontend

Categories

(DevTools :: Console, enhancement, P1)

Product:
DevTools
Component:
Console
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 59

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

Bug 1408932 - Rename and enable browser_webconsole_cspro.js in new frontend; .
59 bytes, text/x-review-board-request
Honza
: review+
Details 
No description provided.
Blocks: 1400847
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8935444 [details]
Bug 1408932 - Rename and enable browser_webconsole_cspro.js in new frontend; .

https://reviewboard.mozilla.org/r/206306/#review212330

Looks reasonable and is passing locally on my machine, just one nit comment.
R+
Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_cspro.js:26
(Diff revision 1)
> -const TEST_VIOLATION = "http://example.com/browser/devtools/client/" +
> -                       "webconsole/test/test_bug_1010953_cspro.html";
> -const CSP_VIOLATION_MSG = "Content Security Policy: The page\u2019s settings " +
> -                          "blocked the loading of a resource at " +
> -                          "http://some.example.com/test.png " +
> -                          "(\u201cimg-src http://example.com\u201d).";
> +                       "new-console-output/test/mochitest/test-cspro.html";
> +const CSP_VIOLATION_MSG =
> +  "Content Security Policy: The page\u2019s settings blocked the loading of a resource " +
> +  "at http://some.example.com/cspro.png (\u201cimg-src http://example.com\u201d).";
> +const CSP_REPORT_MSG =
> +  "Content Security Policy: The page\u2019s settings observed the loading of a resource " +

nit: the line exceeds 90 chars limit
Attachment #8935444 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/150e5c84fc79
Rename and enable browser_webconsole_cspro.js in new frontend; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/150e5c84fc79
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Blocks: 1428006
Product: Firefox → DevTools
status-firefox59: fixed → ---
Duplicate of this bug: 1243967
You need to log in before you can comment on or make changes to this bug.