1408932 - Enable browser_webconsole_cspro.js in the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1408932 - Rename and enable browser_webconsole_cspro.js in new frontend; .

Review commit: https://reviewboard.mozilla.org/r/206306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206306/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8935444 [details]
Bug 1408932 - Rename and enable browser_webconsole_cspro.js in new frontend; .

https://reviewboard.mozilla.org/r/206306/#review212330

Looks reasonable and is passing locally on my machine, just one nit comment.
R+
Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_cspro.js:26
(Diff revision 1)
> -const TEST_VIOLATION = "http://example.com/browser/devtools/client/" +
> -                       "webconsole/test/test_bug_1010953_cspro.html";
> -const CSP_VIOLATION_MSG = "Content Security Policy: The page\u2019s settings " +
> -                          "blocked the loading of a resource at " +
> -                          "http://some.example.com/test.png " +
> -                          "(\u201cimg-src http://example.com\u201d).";
> +                       "new-console-output/test/mochitest/test-cspro.html";
> +const CSP_VIOLATION_MSG =
> +  "Content Security Policy: The page\u2019s settings blocked the loading of a resource " +
> +  "at http://some.example.com/cspro.png (\u201cimg-src http://example.com\u201d).";
> +const CSP_REPORT_MSG =
> +  "Content Security Policy: The page\u2019s settings observed the loading of a resource " +

nit: the line exceeds 90 chars limit

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8935444 [details]
Bug 1408932 - Rename and enable browser_webconsole_cspro.js in new frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206306/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/150e5c84fc79
Rename and enable browser_webconsole_cspro.js in new frontend; r=Honza.

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/150e5c84fc79