1408942 - Enable browser_webconsole_multiple_windows_and_tabs.js in the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1408942 - Enable browser_webconsole_multiple_windows_and_tabs.js;

Review commit: https://reviewboard.mozilla.org/r/203666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203666/

Comment 2

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b46e864c4659966ed379634db9c7ee16e487ce7f

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8932620 [details]
Bug 1408942 - Enable browser_webconsole_multiple_windows_and_tabs.js;

https://reviewboard.mozilla.org/r/203666/#review209388

Looks good, thanks Julian!

Just cuple of inline suggestions.

R+, assuming try is green

Honza

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_multiple_windows_and_tabs.js:28
(Diff revision 1)
> +  info("Open a second window");
> +  const win2 = OpenBrowserWindow();
> +  await new Promise(r => {
> +    win2.addEventListener("load", r, {capture: true, once: true});
> +  });
> +  info("Second window loaded");

Do we need to log this info message? It's immediatelly followed by another info, which could be enough.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_multiple_windows_and_tabs.js:33
(Diff revision 1)
> +  info("Second window loaded");
>  
> -  // Add two tabs in the new window.
> -  addTabs(win2);
> +  info("Add test tabs in second window");
> +  let tab3 = await addTab(TEST_URI, {window: win2});
> +  let tab4 = await addTab(TEST_URI, {window: win2});
> +  info("Test tabs added in second window");

The same as above, perhaps we can reduce the number of logs.

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8932620 [details]
Bug 1408942 - Enable browser_webconsole_multiple_windows_and_tabs.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203666/diff/1-2/

Comment 5

[Julian Descottes [:jdescottes]]

Thanks for the review Honza! Addressed your comments, and try seems green. Landing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5e690295e32
Enable browser_webconsole_multiple_windows_and_tabs.js;r=Honza

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e5e690295e32