1408993 - Allow tabs.create to open URLS in reader mode

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[Bob Silverberg [:bsilverberg]]

I am spinning this off from bug 1371793 because that is more general being about the ability to create a number of different types of about: URLs.

For the reader mode API support we are only interested in the ability to call tabs.create with an about:reader URL, so I am narrowing the scope for this bug. Some discussion has already occurred in bug 1371793, and a security review has been opened via bug 1390035.

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1408993 - Allow tabs.create to create URLS in reader mode,

Review commit: https://reviewboard.mozilla.org/r/189816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189816/

Comment 2

[Bob Silverberg [:bsilverberg]]

Note that this is still awaiting a security review (bug 1390035), but if we can finalize the implementation via this bug that might help facilitate the sec-review.

Comment 3

[Andrew Swan [:aswan]]

Is the proposal that extensions actually constructor about:reader urls?  I think that if we can avoid exposing the url structure that would be good, since there's now a reader more property in Tab objects, how about just adding the same property to create options and creating an appropriate reader url if it is set to true?

Comment 4

[Bob Silverberg [:bsilverberg]]

(In reply to Andrew Swan [:aswan] from comment #3)
> Is the proposal that extensions actually constructor about:reader urls?  I
> think that if we can avoid exposing the url structure that would be good,
> since there's now a reader more property in Tab objects, how about just
> adding the same property to create options and creating an appropriate
> reader url if it is set to true?

That is a very good idea. I will update the patch accordingly.

Comment 5

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8918916 [details]
Bug 1408993 - Allow tabs.create to create URLS in reader mode,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189816/diff/1-2/

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8918916 [details]
Bug 1408993 - Allow tabs.create to create URLS in reader mode,

https://reviewboard.mozilla.org/r/189816/#review194962

r+ with fix

::: browser/components/extensions/ext-tabs.js:351
(Diff revision 2)
>                if (!context.checkLoadURL(url, {dontReportErrors: true})) {
>                  return Promise.reject({message: `Illegal URL: ${url}`});
>                }
> +
> +              if (createProperties.openInReaderMode) {
> +                url = `about:reader?url=${url}`;

${encodeURIComponent(url)}

Comment 7

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8918916 [details]
Bug 1408993 - Allow tabs.create to create URLS in reader mode,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189816/diff/2-3/

Comment 8

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8918916 [details]
Bug 1408993 - Allow tabs.create to create URLS in reader mode,

https://reviewboard.mozilla.org/r/189816/#review194962

> ${encodeURIComponent(url)}

Thanks Shane.

Comment 9

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8918916 [details]
Bug 1408993 - Allow tabs.create to create URLS in reader mode,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/189816/diff/3-4/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/beb6d23925c0
Allow tabs.create to create URLS in reader mode, r=mixedpuppy

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/beb6d23925c0

Comment 12

[Will Bamberg [:wbamberg]]

See: https://bugzilla.mozilla.org/show_bug.cgi?id=1381992#c54 for links to the docs.

Comment 13

[Victor Carciu]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!