Closed
Bug 1409044
Opened 8 years ago
Closed 8 years ago
Spidermonkey builds don't pass an --authentication-file
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
1.97 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
We discovered this while trying to upgrade compilers. Currently, SM builds are succeeding at downloading the VS2015 package only thanks to caching.
Assignee: nobody → dmajor
Attachment #8918904 -
Flags: review?(bugspam.Callek)
Comment 2•8 years ago
|
||
Comment on attachment 8918904 [details] [diff] [review]
smauth
Review of attachment 8918904 [details] [diff] [review]:
-----------------------------------------------------------------
::: taskcluster/scripts/builder/sm-tooltool-config.sh
@@ +55,5 @@
>
> : ${TOOLTOOL_CHECKOUT:=$WORK}
> export TOOLTOOL_CHECKOUT
>
> +(cd $TOOLTOOL_CHECKOUT && ${SRCDIR}/mach artifact toolchain -v $TOOLTOOL_AUTH_FLAGS --tooltool-url $TOOLTOOL_SERVER --tooltool-manifest $SRCDIR/$TOOLTOOL_MANIFEST ${TOOLTOOL_CACHE:+ --cache-dir $TOOLTOOL_CACHE}${MOZ_TOOLCHAINS:+ ${MOZ_TOOLCHAINS}})
probably best to do `-v${TOOLTOOL_AUTH_FLAGS:+ ${TOOLTOOL_AUTH_FLAGS}` like the rest of the vars passed
Attachment #8918904 -
Flags: review?(bugspam.Callek) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c52aabd4f2ee
Pass the tooltool authentication file in Spidermonkey builds. r=Callek
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•