1409045 - Allow Web Extensions to control privacy.firstparty.isolate

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[Tom Ritter [:tjr]]

We would like to expose the privacy.firstparty.isolate preference that is, at this point, pretty well baked. This will allow privacy Web Extensions to toggle it on and take advantage of the work we did.

This will take the same form of Bug 1397611

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1409045 Expose a websites.firstPartyIsolate pref that Web Extensions can toggle

Review commit: https://reviewboard.mozilla.org/r/189948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189948/

Comment 2

[Bob Silverberg [:bsilverberg]]

I notice that there's another WebExtensions bug open (bug 1381197) regarding privacy.firstparty.isolate. Should this be considered alongside that, or are they independent?

Comment 3

[Andrew Swan [:aswan]]

(In reply to Bob Silverberg [:bsilverberg] from comment #2)
> I notice that there's another WebExtensions bug open (bug 1381197) regarding
> privacy.firstparty.isolate. Should this be considered alongside that, or are
> they independent?

These seem totally independent to me

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8919031 [details]
Bug 1409045 Expose a websites.firstPartyIsolate pref that Web Extensions can toggle

https://reviewboard.mozilla.org/r/189948/#review195116

Thanks!

Comment 5

[Mike Conca [:mconca]]

Tom, are you hoping to get this into the 58 release? No issue, just tracking.

Comment 6

[Tom Ritter [:tjr]]

(In reply to Bob Silverberg [:bsilverberg] from comment #2)
> I notice that there's another WebExtensions bug open (bug 1381197) regarding
> privacy.firstparty.isolate. Should this be considered alongside that, or are
> they independent?

Yea, they are independent.

(In reply to Mike Conca [:mconca] (Denver, CO, USA UTC-6) from comment #5)
> Tom, are you hoping to get this into the 58 release? No issue, just tracking.

It would be great if we could since it goes along really well with Bug 1397611

Comment 7

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8919031 [details]
Bug 1409045 Expose a websites.firstPartyIsolate pref that Web Extensions can toggle

https://reviewboard.mozilla.org/r/189948/#review195470

Andrew's already reviewed this, so clearing my flag.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f6d8491f80a
Expose a websites.firstPartyIsolate pref that Web Extensions can toggle r=aswan

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0f6d8491f80a

Comment 10

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.

Comment 11

[Will Bamberg [:wbamberg]]

I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/privacy/websites. I mostly just used the text from the JSON, it seemed really good.

Let me know if this covers it.

Comment 12

[Tom Ritter [:tjr]]

LGTM