1409075 - Reduce the tab process leak threshold to reflect the current state

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Andrew McCreight [:mccr8]]

The tab process leak threshold for reftests is currently 5000 bytes, and the leak threshold for mochitests is 10000 bytes. These can be reduced by a fair amount, which will help avoid regressions.

For reftests, I believe that the threshold can be set to zero, except on Win32, where there is a 1944 byte leak (bug 1408554).

For mochitests, the largest existing leak is bug 1408552, which is a 1336 byte leak on OS X, and is present on all platforms.

I'll add a little bit of overhead, to avoid problems when somebody adds a single new field to a leaking object.

I have filed bugs blocking bug 1401764 for all of the remaining leaks that I see.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Reduce the tab process leak threshold to reflect the current state.

-p all -u all try push:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=24e6fd16ba78396b202d115194de369060787ae8

The failures are in Win64 reftests, so I've adjusted those in the patch here.

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8919368 [details] [diff] [review]
Reduce the tab process leak threshold to reflect the current state.

Review of attachment 8919368 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me assuming the try run is happy.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/438ff19208f4
Reduce the tab process leak threshold to reflect the current state. r=erahm

Comment 4

[Andrew McCreight [:mccr8]]

Hopefully this won't reveal too many intermittent leaks. That's part of why I was conservative with the threshold.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Add a blank line to satisfy the linter.

MozReview-Commit-ID: 6olMm4Y59Xd

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34db1d5769c1
Add a blank line to satisfy the linter. r=bustage DONTBUILD

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/438ff19208f4
https://hg.mozilla.org/mozilla-central/rev/34db1d5769c1