Closed Bug 1409075 Opened 7 years ago Closed 7 years ago

Reduce the tab process leak threshold to reflect the current state

Categories

(Testing :: General, defect)

Version 3
defect
Not set
normal

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MemShrink])

Attachments

(2 files)

The tab process leak threshold for reftests is currently 5000 bytes, and the leak threshold for mochitests is 10000 bytes. These can be reduced by a fair amount, which will help avoid regressions.

For reftests, I believe that the threshold can be set to zero, except on Win32, where there is a 1944 byte leak (bug 1408554).

For mochitests, the largest existing leak is bug 1408552, which is a 1336 byte leak on OS X, and is present on all platforms.

I'll add a little bit of overhead, to avoid problems when somebody adds a single new field to a leaking object.

I have filed bugs blocking bug 1401764 for all of the remaining leaks that I see.
-p all -u all try push:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=24e6fd16ba78396b202d115194de369060787ae8

The failures are in Win64 reftests, so I've adjusted those in the patch here.
Attachment #8919368 - Flags: review?(erahm)
Whiteboard: [MemShrink]
Comment on attachment 8919368 [details] [diff] [review]
Reduce the tab process leak threshold to reflect the current state.

Review of attachment 8919368 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me assuming the try run is happy.
Attachment #8919368 - Flags: review?(erahm) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/438ff19208f4
Reduce the tab process leak threshold to reflect the current state. r=erahm
Keywords: checkin-needed
Hopefully this won't reveal too many intermittent leaks. That's part of why I was conservative with the threshold.
MozReview-Commit-ID: 6olMm4Y59Xd
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34db1d5769c1
Add a blank line to satisfy the linter. r=bustage DONTBUILD
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: