1409093 - stylo: Stylo enabled results in long stalls in Google Inbox

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Selena Deckelmann :selenamarie :selena]

https://perfht.ml/2gJuOUK

I've been working without Stylo for a week as a test. I turned it back on today and am experiencing long stalls in Inbox as well as difficulty clicking on items in the "side bar" of the UI for Inbox (like I click on Inbox after a search, and nothing happens -- waited for 30 seconds for example to see if it was just massively delayed).

Comment 1

[Selena Deckelmann :selenamarie :selena]

https://perfht.ml/2gKQLTM

Here's another profile - opening a few emails and then trying to click on any of the navigation to go to other "mailboxes" to go back to my main inbox. Nothing happens. The last couple seconds are of me clicking around.  I'm not seeing any errors in the developer console.

Comment 2

[Selena Deckelmann :selenamarie :selena]

Switching stylo off, still can't click on navigation. The long stalls to load emails, however, are gone.

Comment 3

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

We should track this bug because Google Inbox is an important website. These Google Inbox perf and navigation problems sound a lot like bug 1407688 that dtownsend filed last week.

@ Selena: can you reproduce these problems in Beta 57?

Comment 4

[Cameron McCormack (:heycam)]

I took a very quick look at the profiles, and don't see much styling happening in there (filtering on "Servo_").  There is a lot of time spent running JS (in reponse to "message" DOM events being posted) and some cycle collection stuff.  Though it's possible that for whatever reason turning on Stylo causes the script to behave differently.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

This sounds potentially bad (maybe a 57 blocker)
Jet, can you help find someone to dig into this further? Thanks!

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

I could not reproduce this in 57.0b9 (Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0) in Gmail with a fresh profile.  I didn't see any delays in loading or navigation after doing searches and clicking around for a bit. 

Andrei, can your team try to reproduce this (and if you see the issue provide a profile?) Thanks.

Comment 7

[Selena Deckelmann :selenamarie :selena]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #6)
> I could not reproduce this in 57.0b9 (Mozilla/5.0 (Macintosh; Intel Mac OS X
> 10.12; rv:57.0) Gecko/20100101 Firefox/57.0) in Gmail with a fresh profile. 
> I didn't see any delays in loading or navigation after doing searches and
> clicking around for a bit. 

Just noting that the issue is with Inbox, not gmail.

Comment 8

[Selena Deckelmann :selenamarie :selena]

I can't repro in Nightly anymore. I wonder if this was a transient Inbox issue. :/ I'm going to close WFM and if it happens again, I'll post profiles for with and without Stylo during the hangs.

Comment 9

[Marcia Knous [:marcia]]

Updating tracking flags for 57 and 58 to get this off the tracking radar.