1409107 - Add theme_icon to page_action

Status: NEW

(WebExtensions :: Frontend, enhancement, P3)

Description

[Andy McKay]

Bug 1329242 added theme_icon for browser_action. We'll need that for page_action as well.

Comment 1

[Potch [:potch]]

The Dark theme for Firefox now changes the location input to a dark color, making this more important.

Comment 2

[rugk]

In https://discourse.mozilla.org/t/how-to-correctly-design-color-icon-to-be-visible-across-themes/27713/10?u=rugkx I've also discovered it and was quite sad. To quote myself:

So this is strange: You can correctly apply the browser action icon (/color), but not the page icon?
IMHO that makes no sense, as your own guide 1 also explains that you should use different colors there, too, for the icon depending on the theme. So when add-ons cannot do this, this is bad.

Comment 3

[Daniele "Mte90" Scasciafratte]

I think that can be closed as page_action doesn't exists anymore, right?