1409141 - Disable fast video upload to D3D11 on Windows 7

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

Bug 1223270 introduced a direct copy of the YUV buffer into a D3D11 surface in order to avoid having to use a copy into an intermediary buffer.

That has shown to crash with old intel drivers on windows 7.

Let's disable this code path on this platform.

It's unreliable, and we can't trust the device driver to tell us if it supports multi threads or not.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1409141 - Disable D3D11 YUV buffer copy on Windows 7.

The crashes on Windows 7 appear to occur due to the D3D11 device being used on two different threads simultaneously. We do query the driver to determine if multithreaded access is supported, but they obviously aren't that cluey about it.

Review commit: https://reviewboard.mozilla.org/r/189910/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189910/

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8919017 [details]
Bug 1409141 - Disable D3D11 YUV buffer copy on Windows 7.

https://reviewboard.mozilla.org/r/189910/#review195040

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/974ca2f1faf5
Disable D3D11 YUV buffer copy on Windows 7. r=mattwoodrow

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/974ca2f1faf5

Comment 5

[Julien Cristau [:jcristau]]

Is the crash volume high enough on nightly to verify there?  If not please request beta uplift when you get a chance.

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8919017 [details]
Bug 1409141 - Disable D3D11 YUV buffer copy on Windows 7.

Approval Request Comment
[Feature/Bug causing the regression]: 1223270 
[User impact if declined]: crashes
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: we revert to Firefox 55 behaviour on Windows 7 machines, which are known to crash for unexplained reasons.
[String changes made/needed]: none

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8919017 [details]
Bug 1409141 - Disable D3D11 YUV buffer copy on Windows 7.

Crash sign family has decent volume in 57, beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e0d56de2214b

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like this fixed a top crash in beta, and this is a high volume crash on release (described in bug 1404456)   jya, if you think this is a good idea to include in a dot release, can you request uplift to m-r?  Thanks!

Comment 10

[Jean-Yves Avenard [:jya]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #9)
> Looks like this fixed a top crash in beta, and this is a high volume crash
> on release (described in bug 1404456)   jya, if you think this is a good
> idea to include in a dot release, can you request uplift to m-r?  Thanks!

yes, I think it would help

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8919017 [details]
Bug 1409141 - Disable D3D11 YUV buffer copy on Windows 7.

Approval Request Comment
[Feature/Bug causing the regression]: 1223270 
[User impact if declined]: crashes
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: we revert to Firefox 55 behaviour on Windows 7 machines, which are known to crash for unexplained reasons.
[String changes made/needed]: none

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8919017 [details]
Bug 1409141 - Disable D3D11 YUV buffer copy on Windows 7.

Crash fix, let's take this for 56.0.2.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/811c42931646

Comment 14

[Andy]

Can this be the cause that 64-bit 56.0.2. now has the "context3d not available possible reasons wrong wmode or missing device support" error with Flash 27.0.0.183 ? (64-bit win10)

Comment 15

[Jean-Yves Avenard [:jya]]

No